Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Xxe #780

Merged
merged 9 commits into from
Nov 20, 2018
Merged

WIP: Xxe #780

merged 9 commits into from
Nov 20, 2018

Conversation

MarkBaker
Copy link
Member

@MarkBaker MarkBaker commented Nov 20, 2018

This is:

- [ ] a bugfix
- [X] a security fix
- [ ] a new feature

Checklist:

Why this change is needed?

Changes to the xml security scanner to use libxml_disable_entity_loader() when cleanly supported and thread-safe, and to handle UTF-7 charset which otherwise permits an XXE exploit

@MarkBaker
Copy link
Member Author

MarkBaker commented Nov 20, 2018

Need to enforce "doctrine/instantiator": "1.0.5" in composer.json (or ^1.0.0) for PHP 5.6; doctrine/instantiator 1.1.0 (if allowed) will break unit tests against PHP 5.6... composer should handle ^1.0.0 correctly when running on travis against 5.6

Copy link
Member

@PowerKiKi PowerKiKi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should probably use lowercase method name

src/PhpSpreadsheet/Reader/Security/XmlScanner.php Outdated Show resolved Hide resolved
src/PhpSpreadsheet/Reader/Security/XmlScanner.php Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants