-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Xxe #780
Conversation
Need to enforce "doctrine/instantiator": "1.0.5" in composer.json (or ^1.0.0) for PHP 5.6; doctrine/instantiator 1.1.0 (if allowed) will break unit tests against PHP 5.6... composer should handle ^1.0.0 correctly when running on travis against 5.6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should probably use lowercase method name
Co-Authored-By: MarkBaker <[email protected]>
Co-Authored-By: MarkBaker <[email protected]>
This is:
Checklist:
Why this change is needed?
Changes to the xml security scanner to use
libxml_disable_entity_loader()
when cleanly supported and thread-safe, and to handle UTF-7 charset which otherwise permits an XXE exploit