Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change usage of boolean to check delimiter #575

Closed
wants to merge 1 commit into from

Conversation

richard-muvirimi
Copy link

@richard-muvirimi richard-muvirimi commented Jul 1, 2018

Instead of checking whether the delimiter has already been set, made it part of the line

This is:

  • performance & bugfix

Checklist:

Instead of checking whether the delimiter has already been set, made it part of the line
Copy link
Member

@PowerKiKi PowerKiKi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not mix code style changes with behavior change. Fix the code style with composer fix. And provide a measure of performance improvement for this patch.

// No leading delimiter
$writeDelimiter = false;
// For no leading delimiter
$_delimiter = "";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

underscore should not be used

@stale
Copy link

stale bot commented Sep 13, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
If this is still an issue for you, please try to help by debugging it further and sharing your results.
Thank you for your contributions.

@stale stale bot added the stale label Sep 13, 2018
@stale stale bot closed this Sep 20, 2018
@oleibman
Copy link
Collaborator

Equivalent change was made by PR #1518.

@oleibman oleibman removed the stale label Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants