Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolution for Issue 3335 - Calculation Engine doesn't evaluate Defined Name when default cell A1 is quote-prefixed #3336

Conversation

MarkBaker
Copy link
Member

This is:

  • a bugfix
  • a new feature
  • refactoring
  • additional unit tests

Checklist:

  • Changes are covered by unit tests
    • Changes are covered by existing unit tests
    • New unit tests have been added
  • Code style is respected
  • Commit message explains why the change is made (see https://github.com/erlang/otp/wiki/Writing-good-commit-messages)
  • CHANGELOG.md contains a short summary of the change and a link to the pull request if applicable
  • Documentation is updated as necessary

Why this change is needed?

Potential resolution for Issue #3355, where the worksheet for a defined name has a quote-prefixed style for default cell A1

I wish _calculateFormulaValue() was private; sadly not

Unit test still to be added.

…d name has a quote-prefixed style for default cell A1.

I wish `_calculateFormulaValue()` was private; sadly not
@MarkBaker MarkBaker changed the title Potential resolution for Issue 3355 Resolution for Issue 3355 - Calculation Engine doesn't evaluate Defined Name when default cell A1 is quote-prefixed Feb 1, 2023
@MarkBaker MarkBaker changed the title Resolution for Issue 3355 - Calculation Engine doesn't evaluate Defined Name when default cell A1 is quote-prefixed Resolution for Issue 3335 - Calculation Engine doesn't evaluate Defined Name when default cell A1 is quote-prefixed Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant