-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor xlsx writer #1922
Refactor xlsx writer #1922
Conversation
* Move file handler creation and file addition to the end
@MarkBaker Can someone help with reviewing this PR |
Can you please make a minor change to your test? Rather than editing your test file in place, copy it to the temporary directory (file_get_contents followed by file_put_contents should suffice), run your test against the temporary copy, and delete the temporary copy at the end. The difference between this and your existing test is that, if something goes wrong, we don't lose the good copy of the test file. |
@oleibman perfect. will make the changes. Edit: This is done |
1dafa16
to
59de56b
Compare
Please unlink the temporary file at the end of your test, and I think this will be good to go. |
As long as GitHub is all green, merging should be fine. But I'll keep an eye open... |
Fix #1911
save()
This is:
Checklist:
Why this change is needed?