conditional style with none border is not preserved when save and load spreadsheet

[ngyuki]

This is:

- [x] a bug report
- [ ] a feature request
- [x] **not** a usage question (ask them on https://stackoverflow.com/questions/tagged/phpspreadsheet or https://gitter.im/PHPOffice/PhpSpreadsheet)

What is the expected behavior?

conditional style with none border is preserved when save and load spreadsheet.

What is the current behavior?

conditional style with none border is not preserved when save and load spreadsheet.

What are the steps to reproduce?

input.xlsx
output.xlsx

<?php

require __DIR__ . '/vendor/autoload.php';

use PhpOffice\PhpSpreadsheet\IOFactory;

$book = IOFactory::load(__DIR__ . '/input.xlsx');
IOFactory::createWriter($book, IOFactory::WRITER_XLSX)->save(__DIR__ . '/output.xlsx');

What features do you think are causing the issue

• Reader
• Writer
• Styles
• Data Validations
• Formula Calculations
• Charts
• AutoFilter
• Form Elements

Does an issue affect all spreadsheet file formats? If not, which formats are affected?

only tested in .xlsx.

Which versions of PhpSpreadsheet and PHP are affected?

php 8.2.2
phpoffice/phpspreadsheet 1.27.1

[oleibman]

Confirmed. When border style is 'none', PhpSpreadsheet is omitting the border tag altogether when writing. This is easily fixed, but exposes another problem - color is automatically set when reading border conditional style even when it is not specified in xml. The combination of the two makes regression problems seem unusually likely, so a fix may take a few days.

[MarkBaker]

I think the issues with defaults on Conditional Styles go a bit deeper still, see Issue #3202

I'd been trying to figure a way of allowing nullable properties when the Style is Conditional, including the Style itself, but not for normal Cell styling... I hadn't come up with an answer though.

[oleibman]

An additional problem is that the spreadsheet produced by Excel has for its conditional border styles left right vertical horizontal, but PhpSpreadsheet produces left right top bottom diagonal. I am not sure if vertical and horizontal are necessary (or how PhpSpreadsheet would know to generate them), but specifying top and bottom definitely throws the formatting off.

[oleibman]

Vertical and horizontal appear to not be needed, at least for this particular problem.

[MarkBaker]

I think we may need to take a step back and look at how Conditional Styles are handled; perhaps we need a separate set of CS classes that extend their corresponding Style classes, but with nullable values and more restricted options; together with a more detailed look at the options available in the different Spreadsheets.
But I hadn't come to any conclusions; and there's a lot more that I'm wanting to look at that's taking a lot of time (my 2.0 release included), so I'd put CS on the back-burner for a while.

[oleibman]

@MarkBaker I am close to a fix for this problem. I need to write some tests, and also check if it's applicable to the other issue you mentioned. I will have something to push today or tomorrow. Part of the problem is that Border(s) is the only Style element that doesn't have special processing for Conditional. It should have, and that's easy to fix. I will submit the PR as a draft to give you a chance to confirm that it's not thwarting any long-term plans.

I won't be able to do anything about vertical/horizontal for the time being. Since a solution for them isn't needed here, that's okay for now. But ... the pseudo-borders are accessible only in Supervisor mode, and the Reader (and probably the Writer) isn't in Supervisor mode when it reads the Conditional Styles and creates the objects. (I do not have a good understanding of Supervisor mode.)