Cell coordinates which are already a range cause an exception

[MaxTingle]

Because Coordinate::mergeRangesInCollection is now used in the the Xlsx worksheet writer for data validation and it doesn't support existing ranges you can no longer call Worksheet\Worksheet setDataValidation with a column range as it'll cause the "Cell coordinate string can not be a range of cells" exception.

PhpSpreadsheet/src/PhpSpreadsheet/Cell/Coordinate.php

Line 405 in 27d83b4

list($column, $row) = self::coordinateFromString($coord);

I suggest moving the definition of $mergedCoordCollection to line 403 then skip coordinate parsing if the coord is already a range like so:

if (strpos($coord, ':') !== false) || (strpos($coord, ',') !== false)) {
     $mergedCoordCollection[$coord] = $value;
     continue;
}

[PowerKiKi]

Would you have a Minimal, Complete, and Verifiable example of code that exhibits this issue ?

[MaxTingle]

Cell range error replication.zip

[PowerKiKi]

Thanks, I can indeed reproduce with your code. Copy/pasted here for convenience:

<?php

require __DIR__ . '/vendor/autoload.php';

use PhpOffice\PhpSpreadsheet\Cell\DataValidation;
use PhpOffice\PhpSpreadsheet\Spreadsheet;
use PhpOffice\PhpSpreadsheet\Writer\Xls;
use PhpOffice\PhpSpreadsheet\Writer\Xlsx;

$spreadsheet = new Spreadsheet();
$spreadsheet->getActiveSheet()->setDataValidation(
    'A1:A2',
    (new DataValidation())
        ->setType(DataValidation::TYPE_LIST)
        ->setShowDropDown(true)
        ->setFormula1('"A,B,C,"')
);

// XLS saving - Works with ranges as it doesn't merge cell coordinates
(new Xls($spreadsheet))->save('out.xls');

// XLSX saving - Worked with ranges before cell coordinates were merged into ranges
(new Xlsx($spreadsheet))->save('out.xlsx');

If you are able to submit a PR with your suggested fix and include unit tests, we might get it to be merged.