Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSV export of fomatted negative number #1009

Closed
ShrekNZ opened this issue Jun 14, 2019 · 1 comment
Closed

CSV export of fomatted negative number #1009

ShrekNZ opened this issue Jun 14, 2019 · 1 comment

Comments

@ShrekNZ
Copy link

ShrekNZ commented Jun 14, 2019

This is: a bug report.

- [x] a bug report

What is the expected behavior?

CSV export of the displayed negative number, even when formatted with a custom format code.

e.g. Number = -70
Format code is: #,##0;[Red]-#,##0

Should export as: "-70"

Old PHPExcel exported these numbers correctly.

What is the current behavior?

Export as a mangled date and format code combination. For example, the above number and format code exports as: "[Sat, 10 Mar 1900 00:00:00 +0000190010]-#,##0"

What are the steps to reproduce?

Create an Excel spreadsheet containing negative numbers formatted with the custom format code shown above. Use attached file: xx1.txt to do this.

Export created spreadsheet as CSV. Use attached file xx2.txt to do this.

Which versions of PhpSpreadsheet and PHP are affected?

PHP 7.3.4
PhpSpreadsheet 1.7.0 (also affected 1.6.0)

xx1.txt
xx2.txt

@MarkBaker
Copy link
Member

resolved in master

PowerKiKi added a commit that referenced this issue Aug 17, 2019
1.9.0

### Added

- When <br> appears in a table cell, set the cell to wrap [#1071](#1071) and [#1070](#1070)
- Add MAXIFS, MINIFS, COUNTIFS and Remove MINIF, MAXIF [#1056](#1056)
- HLookup needs an ordered list even if range_lookup is set to false [#1055](#1055) and [#1076](#1076)
- Improve performance of IF function calls via ranch pruning to avoid resolution of every branches [#844](#844)
- MATCH function supports `*?~` Excel functionality, when match_type=0 [#1116](#1116)
- Allow HTML Reader to accept HTML as a string [#1136](#1136)

### Fixed

- Fix to AVERAGEIF() function when called with a third argument
- Eliminate duplicate fill none style entries [#1066](#1066)
- Fix number format masks containing literal (non-decimal point) dots [#1079](#1079)
- Fix number format masks containing named colours that were being misinterpreted as date formats; and add support for masks that fully replace the value with a full text string [#1009](#1009)
- Stricter-typed comparison testing in COUNTIF() and COUNTIFS() evaluation [#1046](#1046)
- COUPNUM should not return zero when settlement is in the last period [#1020](#1020) and [#1021](#1021)
- Fix handling of named ranges referencing sheets with spaces or "!" in their title
- Cover `getSheetByName()` with tests for name with quote and spaces [#739](#739)
- Best effort to support invalid colspan values in HTML reader - [#878](#878)
- Fixes incorrect rows deletion [#868](#868)
- MATCH function fix (value search by type, stop search when match_type=-1 and unordered element encountered) [#1116](#1116)
- Fix `getCalculatedValue()` error with more than two INDIRECT [#1115](#1115)
- Writer\Html did not hide columns [#985](#985)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants