-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add list-sets command #5635
Add list-sets command #5635
Conversation
@@ -0,0 +1,31 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MaXal , would that fit your needs?
// part one: schema
*/ | ||
protected function createSimpleReport() | ||
{ | ||
return '{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MaXal , would that fit your needs?
// part two: example json result
"$schema": "http://json-schema.org/draft-04/schema#", | ||
"type": "object", | ||
"properties": { | ||
"sets": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was wondering about this special nesting level (let me call it "envelope") -> for now, we don't really need it.
Yet, we had cases in past, when Rule was expecting configuration like [foo, bar]
and we couldn't extend it, causing a BC break to introduce {items => [foo, bar], otherOption: true}
. let's be future ready
Why did the coverage dropped? |
no clue |
@keradus Thank you! I will take a look at JSON format then to make the support more bullet-proof! |
closes #5621
example:
php php-cs-fixer list-sets --format json