Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix petab.visualize.data_overview.create_report #96

Merged
merged 2 commits into from
Nov 30, 2021
Merged

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Nov 30, 2021

  • Fix number of conditions
  • Handle optional preequilibrationConditionId

@dweindl dweindl requested a review from plakrisenko November 30, 2021 08:53
@codecov-commenter
Copy link

codecov-commenter commented Nov 30, 2021

Codecov Report

Merging #96 (dd9ae75) into develop (fde0bf6) will decrease coverage by 0.05%.
The diff coverage is 50.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #96      +/-   ##
===========================================
- Coverage    79.86%   79.81%   -0.06%     
===========================================
  Files           26       26              
  Lines         2950     2952       +2     
  Branches       718      719       +1     
===========================================
  Hits          2356     2356              
- Misses         420      421       +1     
- Partials       174      175       +1     
Impacted Files Coverage Δ
petab/visualize/data_overview.py 93.54% <50.00%> (-6.46%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fde0bf6...dd9ae75. Read the comment docs.

* Fix number of conditions
* Handle optional preequilibrationConditionId

Co-authored-by: Dilan Pathirana <[email protected]>
@dweindl dweindl removed the request for review from plakrisenko November 30, 2021 12:04
@dweindl dweindl merged commit 1cc04bf into develop Nov 30, 2021
@dweindl dweindl deleted the fix_report branch November 30, 2021 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants