Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validator: check prior parameters #279

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Jun 26, 2024

The validation function was there, but was never called...

The validation function was there, but was never called...
@dweindl dweindl requested a review from a team as a code owner June 26, 2024 15:20
@codecov-commenter
Copy link

codecov-commenter commented Jun 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.09%. Comparing base (74ac20d) to head (c5883dd).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #279   +/-   ##
========================================
  Coverage    76.09%   76.09%           
========================================
  Files           36       36           
  Lines         3233     3234    +1     
  Branches       786      786           
========================================
+ Hits          2460     2461    +1     
  Misses         568      568           
  Partials       205      205           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dweindl dweindl self-assigned this Jun 26, 2024
Copy link
Member

@dilpath dilpath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@dweindl dweindl merged commit 7cf18ae into PEtab-dev:develop Jun 26, 2024
7 checks passed
@dweindl dweindl deleted the fix_check_priors branch June 26, 2024 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants