-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify yaml schema #264
Simplify yaml schema #264
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #264 +/- ##
========================================
Coverage 76.33% 76.33%
========================================
Files 36 36
Lines 3228 3228
Branches 783 783
========================================
Hits 2464 2464
Misses 559 559
Partials 205 205 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Top of this file: the URL https://json-schema.org/understanding-json-schema/index.html
could be changed to https://json-schema.org/understanding-json-schema
.
Also confusing to read this is a JSON schema, but it's in YAML. Does the JSON schema cover this YAML document explicitly? Or is it just that this document describes some dictionary that JSON schema is compatible with, but the YAML directly is not supported?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
json-schema has been developed for json, but it can be applied to Python objects. We are applying it to a dict
. It does not check the yaml syntax itself (loading the yaml file will already fail before the validation in case of syntax errors), but only the data model.
|
Avoid repetitions in yaml schema.