Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deprecated functions in tests #181

Merged
merged 5 commits into from
Oct 12, 2022
Merged

Update deprecated functions in tests #181

merged 5 commits into from
Oct 12, 2022

Conversation

yannikschaelte
Copy link
Member

@yannikschaelte yannikschaelte commented Oct 11, 2022

I'd argue that when marking arguments as deprecated, tests should proceed to use the new arguments (and optionally keep some tests using the old ones, but only as extras)?

number of test warnings reduced from ~42 to 5

@yannikschaelte yannikschaelte self-assigned this Oct 11, 2022
Copy link
Member

@dweindl dweindl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd argue that when marking arguments as deprecated, tests should proceed to use the new arguments (and optionally keep some tests using the old ones, but only as extras)?
Generally, I'd say it makes sense to check that the deprecated functionality still works until it is removed. But fine for me to remove in this specific case.

I now added test routines with deprecation warning checks for most of the changed calls

@codecov-commenter
Copy link

Codecov Report

Merging #181 (125e099) into develop (7455e03) will decrease coverage by 0.34%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop     #181      +/-   ##
===========================================
- Coverage    78.06%   77.72%   -0.35%     
===========================================
  Files           29       29              
  Lines         2644     2644              
  Branches       591      591              
===========================================
- Hits          2064     2055       -9     
- Misses         421      431      +10     
+ Partials       159      158       -1     
Impacted Files Coverage Δ
petab/problem.py 64.75% <ø> (-1.92%) ⬇️
petab/parameter_mapping.py 65.96% <0.00%> (-2.10%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@yannikschaelte yannikschaelte merged commit f4a6864 into develop Oct 12, 2022
@yannikschaelte yannikschaelte deleted the fixes_ys2 branch October 12, 2022 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants