Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unreachable TypeError in petab.parameter_mapping.apply_overrides_for_observable #59

Closed
FFroehlich opened this issue Apr 14, 2021 · 2 comments · Fixed by #60
Closed

Unreachable TypeError in petab.parameter_mapping.apply_overrides_for_observable #59

FFroehlich opened this issue Apr 14, 2021 · 2 comments · Fixed by #60
Assignees
@dweindl
Labels
bug Something isn't working

Comments

@FFroehlich
Copy link
Collaborator

I don't think

libpetab-python/petab/parameter_mapping.py

Line 365 in 0917194

except KeyError as e:
can ever be reached.

If overridee_id is not present in mapping, the code will simply add a new entry and not throw a KeyError.
@yannikschaelte
Copy link
Member

that seems correct, as mapping is just a dict. it should likely check for existence of that key instead.

@yannikschaelte yannikschaelte added the bug Something isn't working label Apr 14, 2021
@dweindl dweindl self-assigned this Apr 15, 2021
dweindl added a commit that referenced this issue Apr 15, 2021
@dweindl
Fix unreachable TypeError in petab.parameter_mapping.apply_overrides_…
72a65e6 
…for_observable (fixes #59)

Revert "More informative error messages in case of wrongly set observable and noise parameters (Closes PEtab-dev/PEtab#118) (PEtab-dev/PEtab#155)"

This reverts commit 8fab85e.
@dweindl dweindl mentioned this issue Apr 15, 2021
Merged
@dweindl dweindl linked a pull request Apr 15, 2021 that will close this issue
Fix unreachable TypeError in petab.parameter_mapping.apply_overrides_… #60
Merged
@dweindl
Copy link
Member

dweindl commented Apr 15, 2021

Apparently my fault... not sure what I was thinking back then...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dweindl dweindl

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix unreachable TypeError in petab.parameter_mapping.apply_overrides_… PEtab-dev/libpetab-python
3 participants
@FFroehlich @dweindl @yannikschaelte