Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

incorrect deprecation warning #164

Closed
FFroehlich opened this issue Jul 20, 2022 · 0 comments
Closed

incorrect deprecation warning #164

FFroehlich opened this issue Jul 20, 2022 · 0 comments
Assignees
@dweindl

Comments

@FFroehlich
Copy link
Collaborator

FFroehlich commented Jul 20, 2022 •
edited
Loading

libpetab-python/petab/problem.py

Line 72 in 286494a

warn("Passing `sbml_model`, `sbml_document`, or `sbml_reader` "

says I should import petab.models.SbmlModel but

libpetab-python/petab/models/__init__.py

Line 5 in 286494a

from .model import Model # noqa F401

doesn't import SbmlModel, so the class is only available from petab.models.sbml_model.SbmlModel
@dweindl dweindl self-assigned this Jul 20, 2022
dweindl added a commit that referenced this issue Jul 20, 2022
@dweindl
Fix typehints and deprecation warning
25c7861 
Closes #164
@dweindl dweindl mentioned this issue Jul 20, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dweindl dweindl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@FFroehlich @dweindl