Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validator: output message in case of successful check is added #487

Merged
merged 4 commits into from
Mar 18, 2021
Merged

Validator: output message in case of successful check is added #487

merged 4 commits into from
Mar 18, 2021

Conversation

plakrisenko
Copy link
Member

No description provided.

@plakrisenko plakrisenko requested a review from dweindl November 10, 2020 14:57
@codecov
Copy link

codecov bot commented Nov 10, 2020 •
edited
Loading

Codecov Report

Merging #487 (0113855) into develop (c7a4778) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #487   +/-   ##
========================================
  Coverage    78.43%   78.43%           
========================================
  Files           24       24           
  Lines         2323     2323           
  Branches       549      549           
========================================
  Hits          1822     1822           
  Misses         364      364           
  Partials       137      137
Impacted Files Coverage Δ
petab/lint.py 77.19% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c7a4778...0113855. Read the comment docs.

dweindl
dweindl requested changes Nov 10, 2020
View reviewed changes
petab/petablint.py Outdated Show resolved Hide resolved
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

dweindl
dweindl approved these changes Mar 18, 2021
View reviewed changes
petab/lint.py Outdated Show resolved Hide resolved
@dweindl dweindl changed the title output message in case of successful check is added Validator: output message in case of successful check is added Mar 18, 2021
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@dweindl dweindl merged commit b000937 into develop Mar 18, 2021
@dweindl dweindl deleted the petablint_message branch March 18, 2021 16:26
@dweindl dweindl mentioned this pull request Mar 19, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jvanhoefer jvanhoefer jvanhoefer left review comments

@dweindl dweindl dweindl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@plakrisenko @dweindl @jvanhoefer