Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New create empty observable function (issue 386) #387

Merged
merged 2 commits into from
Mar 16, 2020
Merged

Conversation

MerktSimon
Copy link
Member

New function to create empty observable dataframe

@MerktSimon MerktSimon requested a review from dweindl March 16, 2020 16:57
@codecov
Copy link

codecov bot commented Mar 16, 2020

Codecov Report

Merging #387 into develop will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #387      +/-   ##
===========================================
+ Coverage    77.74%   77.77%   +0.03%     
===========================================
  Files           22       22              
  Lines         2067     2070       +3     
  Branches       475      476       +1     
===========================================
+ Hits          1607     1610       +3     
  Misses         340      340              
  Partials       120      120
Impacted Files Coverage Δ
petab/observables.py 96.61% <100%> (+0.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4fdab26...398a1cf. Read the comment docs.

Copy link
Member

@dweindl dweindl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use more descriptive commit messages / PR titles. Otherwise good ;).

@MerktSimon MerktSimon changed the title Resolve386 New create empty observable function (issue 386) Mar 16, 2020
@MerktSimon MerktSimon merged commit 5e1dec3 into develop Mar 16, 2020
@MerktSimon MerktSimon deleted the resolve386 branch March 16, 2020 17:05
@dweindl dweindl mentioned this pull request Mar 18, 2020
dweindl added a commit that referenced this pull request Mar 18, 2020
Release 0.1.5

Library:

* New create empty observable function (issue 386) (#387)
* Deprecate petab.sbml.globalize_parameters (#381)
* Fix computing log10 likelihood (#380)
* Documentation update and typehints for visualization  (#372)
* Ordered result of `petab.get_output_parameters`
* Fix missing argument to parameters.create_parameter_df

Documentation:
* Add overview of supported PEtab feature in toolboxes
* Add contribution guide
* Fix optional values in documentation (#378)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants