fix tests #42
Open
fix tests #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
abhidg
commented
Feb 17, 2025
abhidg
commented
- Relax requirements pyproject.toml: relax requirements
- tests: fix datasets import
- Re-add l2gv2.example for local2global tests
- ci: use Makefile to run tests
abhidg
force-pushed
the
fix-tests
branch
2 times, most recently
from
9f4ef5f to
4390a0d
Compare
Overly strict requirements makes it difficult to resolve packages. Particularly in this case, many of the projects provide wheels only for the latest version. As L2G will be used as a library, it is reasonable to expect that users may be using slightly different versions of torch, torch-geometric and other fundamental libraries. Relaxing numpy requirement will lead to numpy 2 being installed. Most libraries in the ecosystem support numpy 2 now, so should not be an issue.
abhidg
force-pushed
the
fix-tests
branch
2 times, most recently
from
090e310 to
f0032fe
Compare
Implement tqdm_close() to finish progressbars. The other functions progress.reset() and progress.update() are not needed as we can call tqdm directly.
GraphDataLoader is incomplete, once code stabilises, will redo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.