Remove panic for unaffected dirs + reprocess them if missing #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@benartuso what was the verdict here with @Eric-Laurence |
didn't get to repro this with him yet, were focused on the polars / pandas weirdness...i haven't been able to repro w/ him but can dive in monday. these changes do fix the panic though and will gracefully handle the error he's running into, but i can't get a test working to show it |
gschoeni
approved these changes
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wasn't able to repro what Eric was seeing, but added in graceful error handling here. If we find a dir that should be in the parent commit's db but isn't, we recalculate it on the fly like the changed dirs
Would love to go over this w/ @Eric-Laurence and see if we can get a test to repro and confirm