raidboss: FRU p4 triggers #601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JLGarber
reviewed
Feb 19, 2025
|
Made some very minor delay/duration adjustments after re-testing in game and checking vod, but otherwise this is working as expected and should be ready. |
JLGarber
approved these changes
Feb 22, 2025
github-actions bot
pushed a commit
that referenced
this pull request
Feb 22, 2025
~~Marking this as WIP for now because I want to get it posted for feedback but may not be able to get back to it until next week. ~~ Working versions of these triggers have been tested quite a bit in game, but I changed a few things before PRing so I'm planning to re-test in game next week. (Probably also some typos in the comments, but I need to look again with fresh eyes.) 30c3933
github-actions bot
pushed a commit
that referenced
this pull request
Feb 22, 2025
~~Marking this as WIP for now because I want to get it posted for feedback but may not be able to get back to it until next week. ~~ Working versions of these triggers have been tested quite a bit in game, but I changed a few things before PRing so I'm planning to re-test in game next week. (Probably also some typos in the comments, but I need to look again with fresh eyes.) 30c3933
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
~~Marking this as WIP for now because I want to get it posted for feedback but may not be able to get back to it until next week. ~~
Working versions of these triggers have been tested quite a bit in game, but I changed a few things before PRing so I'm planning to re-test in game next week. (Probably also some typos in the comments, but I need to look again with fresh eyes.)