Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

raidboss: Cloud of Darkness Chaotic #551

Merged
merged 28 commits into from
Jan 6, 2025

Conversation

xiashtra
Copy link
Collaborator

@xiashtra xiashtra commented Dec 27, 2024

Very rough, needs work.

Ready for review. I think the remaining TODO's are non-blocking improvements that could be added later.

@github-actions github-actions bot added 💬ko 💬cn raidboss /ui/raidboss module 💬de 💬ja 💬fr oopsy /ui/oopsyraidsy module labels Dec 27, 2024
Copy link
Collaborator

@valarnin valarnin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this is WIP but thought I would add some feedback ahead of time.

@xiashtra
Copy link
Collaborator Author

After working on the diamond phase timeline some more, it looks like there's really only a Flare branch and a Death IV/Aero IV branch, rather than three seperate branches. I might merge the Death IV and Aero IV branches together.

@github-actions github-actions bot removed the oopsy /ui/oopsyraidsy module label Dec 28, 2024
Copy link
Collaborator

@JLGarber JLGarber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far, thanks for putting that together. I haven't had much time to run this after week 1, so I don't have much more to offer on it, but this looks like a solid base to start with.

// 9E51 = dummy cast from adds (source: Sinister Eye)
// 9E52 = actual cast from adds (sometimes has stale source name)
netRegex: { id: '9E4F', source: 'Cloud of Darkness', capture: false },
response: Responses.lookAway(),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't looked through the logs too hard, but is it going to be possible to math out where the adds are and then call one of the safe intercardinals for the player to look at? If so, maybe we could put that in the TODO list?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be possible, but it would be more delayed than the current trigger. It looks like the Sinister Eyes spawn in off-map to the east, then move into location right before they start casting.

@valarnin
Copy link
Collaborator

valarnin commented Jan 2, 2025

These have been fine for me in my testing so far. The only direct suggestion I have is to add a tank swap trigger for the stacking lightning vuln in p1, maybe at 5 stacks?

@xiashtra
Copy link
Collaborator Author

xiashtra commented Jan 2, 2025

These have been fine for me in my testing so far. The only direct suggestion I have is to add a tank swap trigger for the stacking lightning vuln in p1, maybe at 5 stacks?

I haven't seen tanks handling that in a consistent manner; some swap as often as possible, some swap when they get yelled at in party chat 😆 It's been all over the place. If there's a recommended value that works for all tank pairings maybe it could be added.

@valarnin
Copy link
Collaborator

valarnin commented Jan 2, 2025

I haven't seen tanks handling that in a consistent manner; some swap as often as possible, some swap when they get yelled at in party chat 😆 It's been all over the place. If there's a recommended value that works for all tank pairings maybe it could be added.

I can confirm that it will stack to at least 14, and at 14 stacks the auto hits for 150k.

@xiashtra
Copy link
Collaborator Author

xiashtra commented Jan 2, 2025

Finished with the rest of the timeline. I'm marking this one as ready for review; I don't think the remaining TODO's are blockers, and they could be added as improvements later.

@xiashtra xiashtra marked this pull request as ready for review January 2, 2025 07:44
@github-actions github-actions bot added the needs-review Awaiting review label Jan 2, 2025
@xiashtra xiashtra changed the title [WIP] raidboss: Cloud of Darkness Chaotic raidboss: Cloud of Darkness Chaotic Jan 2, 2025
@xiashtra
Copy link
Collaborator Author

xiashtra commented Jan 3, 2025

These have been fine for me in my testing so far. The only direct suggestion I have is to add a tank swap trigger for the stacking lightning vuln in p1, maybe at 5 stacks?

Added a swap trigger for 5+ stacks.

@wexxlee
Copy link
Collaborator

wexxlee commented Jan 5, 2025

I mistakenly tested this today against an older commit, and it looks like you may have already addressed what I was going to say. 😄 . I should be able to re-test this tomorrow afternoon.

@github-actions github-actions bot removed the needs-review Awaiting review label Jan 6, 2025
@xiashtra xiashtra merged commit 2b614ee into OverlayPlugin:main Jan 6, 2025
11 checks passed
@xiashtra xiashtra deleted the cloud-chaotic branch January 6, 2025 21:56
github-actions bot pushed a commit that referenced this pull request Jan 6, 2025
~~Very rough, needs work.~~

Ready for review. I think the remaining TODO's are non-blocking
improvements that could be added later.

---------

Co-authored-by: valarnin <[email protected]> 2b614ee
github-actions bot pushed a commit that referenced this pull request Jan 6, 2025
~~Very rough, needs work.~~

Ready for review. I think the remaining TODO's are non-blocking
improvements that could be added later.

---------

Co-authored-by: valarnin <[email protected]> 2b614ee
github-actions bot pushed a commit to ShadyWhite/cactbot that referenced this pull request Jan 7, 2025
~~Very rough, needs work.~~

Ready for review. I think the remaining TODO's are non-blocking
improvements that could be added later.

---------

Co-authored-by: valarnin <[email protected]> 2b614ee
github-actions bot pushed a commit to ShadyWhite/cactbot that referenced this pull request Jan 7, 2025
~~Very rough, needs work.~~

Ready for review. I think the remaining TODO's are non-blocking
improvements that could be added later.

---------

Co-authored-by: valarnin <[email protected]> 2b614ee
github-actions bot pushed a commit to AinaSnow/cactbot that referenced this pull request Jan 7, 2025
~~Very rough, needs work.~~

Ready for review. I think the remaining TODO's are non-blocking
improvements that could be added later.

---------

Co-authored-by: valarnin <[email protected]> 2b614ee
github-actions bot pushed a commit to AinaSnow/cactbot that referenced this pull request Jan 7, 2025
~~Very rough, needs work.~~

Ready for review. I think the remaining TODO's are non-blocking
improvements that could be added later.

---------

Co-authored-by: valarnin <[email protected]> 2b614ee
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants