raidboss: Improvements to FRU P2 timeline #537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
raidboss
kshman
reviewed
Dec 8, 2024
wexxlee
reviewed
Dec 8, 2024
wexxlee
reviewed
Dec 8, 2024
| @@ -135,7 +139,9 @@ hideall "--sync--" | |||
| 450.5 "Sinbound Blizzard III" Ability { id: "9D42", source: "Crystal of Darkness" } | |||
|
|
|||
| # Phase Three | |||
| 488.8 "--sync--" WasDefeated { source: 'Ice Veil' } window 488.8,10 | |||
There was a problem hiding this comment.
I think this is target: Ice Veil
wexxlee
approved these changes
Dec 8, 2024
There was a problem hiding this comment.
Approving now, just see my added comment about the Phase 3 sync. Also, it might've gotten lost in the comments because GH is annoying about tagging the right line for review comments, but these lines also have varying source names and we might want to remove the source prop. Leave it up to you though:
247.2 "Frigid Stone" Ability { id: "9D07", source: "Usurper of Frost" }
247.6 "Icicle Impact" Ability { id: "9D06", source: "Usurper of Frost" }
251.6 "Icicle Impact" Ability { id: "9D06", source: "Usurper of Frost" }
254.2 "Frigid Needle" Ability { id: "9D08", source: "Usurper of Frost" }
255.5 "Icicle Impact" Ability { id: "9D06", source: "Usurper of Frost" }
wexxlee
added a commit
that referenced
this pull request
Dec 8, 2024
Per discussion in discord. There's an intermittent issue with stale position data on `StartsUsing` lines for Icicle Impact; this switches to `StartsUsingExtra`, which resolves the issue. I'd like to version bump again after this and #537 are merged, as this is a bug fix.
github-actions bot
pushed a commit
to ShadyWhite/cactbot
that referenced
this pull request
Dec 8, 2024
Per discussion in discord. There's an intermittent issue with stale position data on `StartsUsing` lines for Icicle Impact; this switches to `StartsUsingExtra`, which resolves the issue. I'd like to version bump again after this and OverlayPlugin#537 are merged, as this is a bug fix. 084f59e
github-actions bot
pushed a commit
to ShadyWhite/cactbot
that referenced
this pull request
Dec 8, 2024
Per discussion in discord. There's an intermittent issue with stale position data on `StartsUsing` lines for Icicle Impact; this switches to `StartsUsingExtra`, which resolves the issue. I'd like to version bump again after this and OverlayPlugin#537 are merged, as this is a bug fix. 084f59e
github-actions bot
pushed a commit
that referenced
this pull request
Dec 8, 2024
This has been tested in-game. I adjusted some timings to better match what I saw across my logs to match `test_timeline` and added the remaining `targetable` entries. I also combined the Shining and Frost armor entries since those always go off simultaneously but the order in the log is random. Finally, I filled out some more data on the P2 abilities in the ability list. Timings for intermission and beyond have not been modified. 291ea8b
github-actions bot
pushed a commit
that referenced
this pull request
Dec 8, 2024
This has been tested in-game. I adjusted some timings to better match what I saw across my logs to match `test_timeline` and added the remaining `targetable` entries. I also combined the Shining and Frost armor entries since those always go off simultaneously but the order in the log is random. Finally, I filled out some more data on the P2 abilities in the ability list. Timings for intermission and beyond have not been modified. 291ea8b
wexxlee
added a commit
that referenced
this pull request
Dec 8, 2024
Hotfix for the FRU P2 Icicle Impact issue. We can merge #537 before merging this (once approved). My remaining comment on it is trivial and can be addressed in a follow up PR.
github-actions bot
pushed a commit
to ShadyWhite/cactbot
that referenced
this pull request
Dec 8, 2024
Hotfix for the FRU P2 Icicle Impact issue. We can merge OverlayPlugin#537 before merging this (once approved). My remaining comment on it is trivial and can be addressed in a follow up PR. 17d4452
github-actions bot
pushed a commit
to ShadyWhite/cactbot
that referenced
this pull request
Dec 8, 2024
Hotfix for the FRU P2 Icicle Impact issue. We can merge OverlayPlugin#537 before merging this (once approved). My remaining comment on it is trivial and can be addressed in a follow up PR. 17d4452
|
Ah, thanks for taking care of that. I was out with family all day and wasn't able to check in on things. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has been tested in-game. I adjusted some timings to better match what I saw across my logs to match
test_timelineand added the remainingtargetableentries. I also combined the Shining and Frost armor entries since those always go off simultaneously but the order in the log is random. Finally, I filled out some more data on the P2 abilities in the ability list.Timings for intermission and beyond have not been modified.