Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

raidboss: Basic FRU P1 triggers #516

Merged
merged 3 commits into from
Dec 1, 2024

Conversation

JLGarber
Copy link
Collaborator

This is partially based on an experimental set of triggers @valarnin tossed in the ACT Discord server yesterday or the day before. I wasn't able to get the Blasting Zone safe area triggers working, but apart from that and the tank buster trigger, everything in here is stuff I was able to test tonight and confirm as working. The timing for delays and durations is all stuff that fits relatively closely to match mechanics. (Castbars in phase 1 are a little longer than we're used to.)

@valarnin
Copy link
Collaborator

Blasting Zone safe area

Did you mean the Utopian Sky safe spots? That set of triggers should have been pretty simple/not prone to failure, and I didn't have any issues with my WIP stuff during in-game testing tonight.

Clones spawn at the start of the fight, then during Utopian Sky they get their position set, and then get an ActorControlExtra line to play the animation for arm lifting.

Here's an example of the lines for one actor:

03|2024-11-27T23:19:14.3620000-05:00|400289E8|Fatebreaker's Image|
26|2024-11-27T23:20:34.8500000-05:00|655|Concealed|9999.00|E0000000||400289E8|Fatebreaker's Image|01|188300|
271|2024-11-27T23:20:34.8500000-05:00|400289E8|-1.5709|00|00|120.0000|100.0000|0.0000|
273|2024-11-27T23:20:36.9860000-05:00|400289E8|003F|4|0|0|0|

There's enough delay between the 271 and 273 lines that there shouldn't ever be a case of out-of-order lines, I think...

@JLGarber
Copy link
Collaborator Author

I'm not sure. I saw exactly one successful activation on those triggers yesterday while running, and it was north/south safe. Unfortunately I wasn't in a position to stop and debug things since we were chain pulling, so I didn't get to see whether there were any errors in the ACT console. I'll give it another attempt tonight and try to do some scrollback during our break maybe.

@github-actions github-actions bot removed the needs-review Awaiting review label Dec 1, 2024
@xiashtra
Copy link
Collaborator

xiashtra commented Dec 1, 2024

I'm not sure. I saw exactly one successful activation on those triggers yesterday while running, and it was north/south safe. Unfortunately I wasn't in a position to stop and debug things since we were chain pulling, so I didn't get to see whether there were any errors in the ACT console. I'll give it another attempt tonight and try to do some scrollback during our break maybe.

For what it's worth, when I tested @valarnin's initial triggers in-instance they all worked without issue.

@github-actions github-actions bot added the needs-review Awaiting review label Dec 1, 2024
@JLGarber
Copy link
Collaborator Author

JLGarber commented Dec 1, 2024

Quickly pushing during break with issues addressed. I'm not sure what I did wrong when I originally tested the Utopian Sky triggers, but re-adding them worked this time.

Copy link
Collaborator

@xiashtra xiashtra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We might want to add some comments separating the different phases so people can work in different parts of the same file without causing a lot of merge conflicts.

@github-actions github-actions bot removed the needs-review Awaiting review label Dec 1, 2024
@JLGarber JLGarber merged commit ebc1d3c into OverlayPlugin:main Dec 1, 2024
10 checks passed
github-actions bot pushed a commit that referenced this pull request Dec 1, 2024
This is partially based on an experimental set of triggers @valarnin
tossed in the ACT Discord server yesterday or the day before. I wasn't
able to get the Blasting Zone safe area triggers working, but apart from
that and the tank buster trigger, everything in here is stuff I was able
to test tonight and confirm as working. The timing for delays and
durations is all stuff that fits relatively closely to match mechanics.
(Castbars in phase 1 are a little longer than we're used to.) ebc1d3c
github-actions bot pushed a commit that referenced this pull request Dec 1, 2024
This is partially based on an experimental set of triggers @valarnin
tossed in the ACT Discord server yesterday or the day before. I wasn't
able to get the Blasting Zone safe area triggers working, but apart from
that and the tank buster trigger, everything in here is stuff I was able
to test tonight and confirm as working. The timing for delays and
durations is all stuff that fits relatively closely to match mechanics.
(Castbars in phase 1 are a little longer than we're used to.) ebc1d3c
@JLGarber JLGarber deleted the fru-p1-triggers branch December 2, 2024 02:35
github-actions bot pushed a commit to ShadyWhite/cactbot that referenced this pull request Dec 2, 2024
This is partially based on an experimental set of triggers @valarnin
tossed in the ACT Discord server yesterday or the day before. I wasn't
able to get the Blasting Zone safe area triggers working, but apart from
that and the tank buster trigger, everything in here is stuff I was able
to test tonight and confirm as working. The timing for delays and
durations is all stuff that fits relatively closely to match mechanics.
(Castbars in phase 1 are a little longer than we're used to.) ebc1d3c
github-actions bot pushed a commit to ShadyWhite/cactbot that referenced this pull request Dec 2, 2024
This is partially based on an experimental set of triggers @valarnin
tossed in the ACT Discord server yesterday or the day before. I wasn't
able to get the Blasting Zone safe area triggers working, but apart from
that and the tank buster trigger, everything in here is stuff I was able
to test tonight and confirm as working. The timing for delays and
durations is all stuff that fits relatively closely to match mechanics.
(Castbars in phase 1 are a little longer than we're used to.) ebc1d3c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants