raidboss: FRU initial P1 timeline #515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
raidboss
|
If you want to stub out P2 for custom timeline entries, it looks like: I don't want to make a separate PR that would conflict with yours until yours is merged. |
valarnin
approved these changes
Nov 28, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Nov 28, 2024
Untested in-game, but `test_timeline` passes More Than Twenty-Five pulls from my logs tonight, so it's probably good enough structurally. Definitely need some criticism on whether it's too cluttered or not cluttered enough, as well as basic sanity checking given I finished this after 2 AM. 248ccbd
|
@xpdota sorry I didn't have time to check in on things today. It does look like we've done that before for Omega Ultimate, so if you have pulls that include phase 2, it might be better to include that phase transition in the next work we do on phase 2. |
github-actions bot
pushed a commit
that referenced
this pull request
Nov 28, 2024
Untested in-game, but `test_timeline` passes More Than Twenty-Five pulls from my logs tonight, so it's probably good enough structurally. Definitely need some criticism on whether it's too cluttered or not cluttered enough, as well as basic sanity checking given I finished this after 2 AM. 248ccbd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Untested in-game, but
test_timelinepasses More Than Twenty-Five pulls from my logs tonight, so it's probably good enough structurally. Definitely need some criticism on whether it's too cluttered or not cluttered enough, as well as basic sanity checking given I finished this after 2 AM.