raidboss: use ActorControlExtra for sidewise spark cleaves #483
Conversation
Valarnin recently did some work to improve the Twilight Sabbath triggers in m4s. He discovered that we can detect the Wicked Replica cleave directions using the ActorControlExtra log lines with the 0197 'PlayActionTimeline' category. Do the same in m4n, replacing the check for CombatantMemory trigger. This should be more precise and less overhead. It is also slightly less code. As far as I can tell, all the clones use the same 11D6 and1 11D8 values for their left or right cleave. Signed-off-by: Jacob Keller <[email protected]>
github-actions
bot
added
raidboss
|
I've tested this on live game, and it works the same so far. I think this is preferable over combatant memory, but I think we still can't get rid of getcombatants entirely. |
|
For context here, That's also why there are only two values for The actual cast animation (that has the lightning VFX and includes the red "omen" cleave indicators on the floor) is still tied to the I just wanted to share the logic/reasoning of why |
Thanks! Ya, I figured the savage version had a fast and slow animation variant since they need time between coming down and going off for the in between mechanics to hit. |
|
For what its worth in my testing, the timing for the ActorControlExtra log lines and the combatant memory log lines appears to be very similar. |
Hmmm that's interesting. In my logs it seems to appear at nearly the same time ... My understanding is that combatant memory relies on polling to check for and emit the matched log lines? The delay probably only matters for the first hit anyway |
|
The timestamp of combatant memory log lines ( In the normal version of the fight, the network packet that actually changes the Below is a quick grep of the three lines from some of my log files. Sorry about the age of these, I haven't touched the normal version of the fight in forever. But the tl;dr is:
|
…eaves (#483) Valarnin recently did some work to improve the Twilight Sabbath triggers in m4s. He discovered that we can detect the Wicked Replica cleave directions using the ActorControlExtra log lines with the 0197 'PlayActionTimeline' category. Do the same in m4n, replacing the check for CombatantMemory trigger. This should be more precise and less overhead. It is also slightly less code. As far as I can tell, all the clones use the same 11D6 and1 11D8 values for their left or right cleave. Signed-off-by: Jacob Keller <[email protected]> Signed-off-by: Jacob Keller <[email protected]> 1c00202
…eaves (#483) Valarnin recently did some work to improve the Twilight Sabbath triggers in m4s. He discovered that we can detect the Wicked Replica cleave directions using the ActorControlExtra log lines with the 0197 'PlayActionTimeline' category. Do the same in m4n, replacing the check for CombatantMemory trigger. This should be more precise and less overhead. It is also slightly less code. As far as I can tell, all the clones use the same 11D6 and1 11D8 values for their left or right cleave. Signed-off-by: Jacob Keller <[email protected]> Signed-off-by: Jacob Keller <[email protected]> 1c00202
Valarnin recently did some work to improve the Twilight Sabbath triggers
in m4s. He discovered that we can detect the Wicked Replica cleave
directions using the ActorControlExtra log lines with the 0197
'PlayActionTimeline' category.
Do the same in m4n, replacing the check for CombatantMemory trigger.
This should be more precise and less overhead. It is also slightly less
code.
As far as I can tell, all the clones use the same 11D6 and1 11D8 values
for their left or right cleave.
Signed-off-by: Jacob Keller [email protected]