-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
raidboss: r4s strategy options for NA strats #453
raidboss: r4s strategy options for NA strats #453
Conversation
The Sunrise callouts could be modified to also call wall baits as an option too; the tower/cannon priority is the same and only the baiting direction is different. |
Ya. I can probably include that as another option. My group (and most PFs) seem to do uptime strategy so that's what I implemented. |
I see a good mix of both in PF which is why I suggested it. |
7bd3748
to
46e293e
Compare
I've updated the descriptions, renamed the strategy as "snakes prio" to match the way its discussed in the various sites. I split the uptime callouts from the priority system so now it will call the direction to bait properly for non-uptime spots. Hopefully this version looks good! I'll be testing it in a live run tonight. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks promising. My group is done with reclears, so not sure when I will find time to get back in to test -- but a few initial comments in the meantime.
1bf2bb8
to
be99dc0
Compare
05ba9ee
to
e160697
Compare
@xiashtra can you re-check this? I think I've fixed all your concerns. I also took the time to squash everything down since I had a lot of fixes that made reviewing individual commits more difficult. |
67ecfc6
to
aae9da4
Compare
50d62b2
to
1b6d67d
Compare
I updated the witchhunt callout to always put bait first. I think that's easier to parse, and certainly easier for a shot caller to use. |
During Witch Hunt, players need to bait aoes so that no player takes the Witch Hunt AoE twice. Currently, we callout either "Baits near (Party Far)" or "Baits Far (Party Near)". Users can customize these if they use a strategy which has fixed ordering (say, Tanks, Healers, Melee, Ranged). However, the standard NA strat is the "DN" strat which uses a flexible ordering for update, where Tanks and Melees prioritize the close/in spots. This cannot be implemented as-is just with custom strings. Add a new strategy option which implements the DN priority bate strategy. I tried to make a shared function it ended up being worse than just duplicating the local lambda function used here. In addition to modifying the alert callout for when to be in/out and close/far, also modify the combined starting callout. Instead of calling "close/far" for the baits, call the order of who baits, i.e.: "In (Tanks) => Out (Healers) => In (Melee) => Out (Ranged)" Note that we don't need to call "tanks close/far" because this strategy always has tanks and melee baiting close while range and healers bait far. We could determine if the player is the appropriate target and switch the order, calling "Party Close (<role> Far)". This changes the trigger text which might help some folks, but makes it more difficult to parse overall, in my opinion. In addition, it is not reliably possible to parse the DPS spots, because not all parties have 2 melee or ranged players, and often assign someone to be "fake melee". Signed-off-by: Jacob Keller <[email protected]>
The standard strategy for resolving the debuffs during Ion Cluster is the "DN" strat, which uses assigned positions for each debuff based on the rivets in the platform. For the blue donut and point-blank AoEs, players go to the two rivets closest to the boss, with support going left, DPS going right. For the purple "get hit" debuff, players go to the rivet on the very middle of the square platform chunk. For the near/far conal debuff, that player goes just in front of the middle rivet closest to the player on the middle rivet. Add a strategy option for ion cluster which can select between the current default of no strategy and the DN strategy. To make this a bit less verbose, convert the callout into a response and dynamically assign the output strings based on the strategy. This could conceivably enable additional strategies easily if other data centers use something else. For this to work, the two sets of output strings must have support and dps specific variants of the roundhouse and spinning conductor debuffs. While the strategy involves use of the rivets on the square tiles, the callouts are simplified to use "front left" or "front right" for the aoes, and "front of middle" or "middle, behind current" for the cone-related debuffs. Signed-off-by: Jacob Keller <[email protected]>
Currently the sunrise sabaath callouts do not include any strategy information. This makes the callout indicate both towers, as well as the spots for both cannons. The standard NA strategy is the "AutoCAD Uptime" strategy which uses the uptime waymarks, and a priority system where support players start looking NW and counter clockwise while DPS players look north and clockwise. For towers, this means DPS always take the north or east tower, while support always take the south or west tower. For cannons, supports will take the first cannon that fits, either NW, SW, or rarely SE. DPS will take the first that fits from NE, SE, or rarely SW. The uptime waymarks also have specific bait spots on the waymarks the side closest to the towers. Add strategy options to enable callouts based on the priority order, and based on whether you use the uptime positions with waymarks. Signed-off-by: Jacob Keller <[email protected]>
1b6d67d
to
8f590e8
Compare
I'd like to know if anyone thinks this needs more changes :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't been able to test this as much as I would have liked (groups are regularly skipping Sunrise), but everything seems to be working ok from what limited testing I was able to do.
This series includes several strategy options for the m4s fight that fit the standard NA PF strategies. - **raidboss: add support for DN strategy for Ion Cluster in m4s** - **raidboss: add support for DN strategy during Witch Hunt in m4s** - **raidboss: add uptime sunrise sabaath callouts in m4s** These are based off the shabin pastebin and hector guide, with the uptime waymarks strategy for sunrise sabaath. I made all of these configuration options, so that existing default callouts which do not use a specific strategy are not affected. I tried to put good brief explanations, and used the standard strat names I see going around. I've tested variations of this code in my runs, though it did not use a strategy option at the time. Thus, this exact code is not yet battle tested outside of the simulator. --------- Signed-off-by: Jacob Keller <[email protected]> 2d8a434
This series includes several strategy options for the m4s fight that fit the standard NA PF strategies. - **raidboss: add support for DN strategy for Ion Cluster in m4s** - **raidboss: add support for DN strategy during Witch Hunt in m4s** - **raidboss: add uptime sunrise sabaath callouts in m4s** These are based off the shabin pastebin and hector guide, with the uptime waymarks strategy for sunrise sabaath. I made all of these configuration options, so that existing default callouts which do not use a specific strategy are not affected. I tried to put good brief explanations, and used the standard strat names I see going around. I've tested variations of this code in my runs, though it did not use a strategy option at the time. Thus, this exact code is not yet battle tested outside of the simulator. --------- Signed-off-by: Jacob Keller <[email protected]> 2d8a434
This series includes several strategy options for the m4s fight that fit the
standard NA PF strategies.
These are based off the shabin pastebin and hector guide, with the uptime
waymarks strategy for sunrise sabaath.
I made all of these configuration options, so that existing default callouts
which do not use a specific strategy are not affected. I tried to put good
brief explanations, and used the standard strat names I see going around.
I've tested variations of this code in my runs, though it did not use a
strategy option at the time. Thus, this exact code is not yet battle tested
outside of the simulator.