Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n: replace sync for dt hunts #386

Merged
merged 3 commits into from
Aug 27, 2024

Conversation

Souma-Sumire
Copy link
Collaborator

  • I couldn't find the script, so this is done manually.
  • Not sure if the German part of 'Kirlirger the Abhorrent' is correct.
  • Not sure if the escape characters are handled correctly.

@github-actions github-actions bot added raidboss /ui/raidboss module needs-review Awaiting review labels Aug 26, 2024
@github-actions github-actions bot removed the needs-review Awaiting review label Aug 27, 2024
@github-actions github-actions bot added the needs-review Awaiting review label Aug 27, 2024
@xiashtra xiashtra requested a review from Akurosia August 27, 2024 08:46
@Akurosia
Copy link
Collaborator

Generally looks good to me, only thing in my mind: usually we only translate stuff for which we have data and since non of them currently have s-rank data i am not 100% sure if we wanna keep the s-rank translations in it (i am fine with either tbh, just a generall question)

Akurosia added a commit to Akurosia/cactbot that referenced this pull request Aug 27, 2024
@xiashtra
Copy link
Collaborator

Generally looks good to me, only thing in my mind: usually we only translate stuff for which we have data and since non of them currently have s-rank data i am not 100% sure if we wanna keep the s-rank translations in it (i am fine with either tbh, just a generall question)

Hmm, you're right that in the past we've only translated the S-rank names once their triggers were added. I'm not sure if it would be preferable to remove them here and wait to re-add them later if/when the triggers are made. @wexxlee or anyone else: thoughts?

@Souma-Sumire
Copy link
Collaborator Author

I have no objections; you can freely edit this pull request to release the version.

@github-actions github-actions bot removed the needs-review Awaiting review label Aug 27, 2024
@wexxlee
Copy link
Collaborator

wexxlee commented Aug 27, 2024

Hmm, you're right that in the past we've only translated the S-rank names once their triggers were added. I'm not sure if it would be preferable to remove them here and wait to re-add them later if/when the triggers are made. @wexxlee or anyone else: thoughts?

I think it's fine to add them now. Generally agree with the philosophy that we shouldn't pre-translate for things we don't have data for yet (since they could change before getting added, or not used, etc. etc.), but in this case, we know the S-ranks will be added (Soon) and the names won't change, so no harm in keeping them.

@wexxlee wexxlee merged commit 69b12dc into OverlayPlugin:main Aug 27, 2024
11 checks passed
github-actions bot pushed a commit that referenced this pull request Aug 27, 2024
- I couldn't find the script, so this is done manually.
- Not sure if the German part of 'Kirlirger the Abhorrent' is correct.
- Not sure if the escape characters are handled correctly. 69b12dc
github-actions bot pushed a commit that referenced this pull request Aug 27, 2024
- I couldn't find the script, so this is done manually.
- Not sure if the German part of 'Kirlirger the Abhorrent' is correct.
- Not sure if the escape characters are handled correctly. 69b12dc
@Souma-Sumire Souma-Sumire deleted the hunt-replaceSync branch August 27, 2024 16:36
wexxlee pushed a commit that referenced this pull request Aug 27, 2024
If #386 is ready before the servers come up, that could be included as
well.

includes:
- more Savage
- Strayborough Deadwalk
- Worqor Lar Dor normal
- A-rank Hunts
- more i18n
github-actions bot pushed a commit that referenced this pull request Aug 27, 2024
If #386 is ready before the servers come up, that could be included as
well.

includes:
- more Savage
- Strayborough Deadwalk
- Worqor Lar Dor normal
- A-rank Hunts
- more i18n d08f377
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
raidboss /ui/raidboss module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants