-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
i18n: replace sync for dt hunts #386
Conversation
Souma-Sumire
commented
Aug 26, 2024
- I couldn't find the script, so this is done manually.
- Not sure if the German part of 'Kirlirger the Abhorrent' is correct.
- Not sure if the escape characters are handled correctly.
Generally looks good to me, only thing in my mind: usually we only translate stuff for which we have data and since non of them currently have s-rank data i am not 100% sure if we wanna keep the s-rank translations in it (i am fine with either tbh, just a generall question) |
Hmm, you're right that in the past we've only translated the S-rank names once their triggers were added. I'm not sure if it would be preferable to remove them here and wait to re-add them later if/when the triggers are made. @wexxlee or anyone else: thoughts? |
I have no objections; you can freely edit this pull request to release the version. |
I think it's fine to add them now. Generally agree with the philosophy that we shouldn't pre-translate for things we don't have data for yet (since they could change before getting added, or not used, etc. etc.), but in this case, we know the S-ranks will be added (Soon) and the names won't change, so no harm in keeping them. |
- I couldn't find the script, so this is done manually. - Not sure if the German part of 'Kirlirger the Abhorrent' is correct. - Not sure if the escape characters are handled correctly. 69b12dc
- I couldn't find the script, so this is done manually. - Not sure if the German part of 'Kirlirger the Abhorrent' is correct. - Not sure if the escape characters are handled correctly. 69b12dc
If #386 is ready before the servers come up, that could be included as well. includes: - more Savage - Strayborough Deadwalk - Worqor Lar Dor normal - A-rank Hunts - more i18n