Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing translation for resources/example_log_lines.ts ? #157

Closed
mooondark opened this issue May 27, 2024 · 1 comment · Fixed by #165
Closed

Missing translation for resources/example_log_lines.ts ? #157

mooondark opened this issue May 27, 2024 · 1 comment · Fixed by #165
Assignees
@wexxlee
Labels
fix-me Bug report validated or feature request planned question Request for information

Comments

@mooondark
Copy link
Collaborator

mooondark commented May 27, 2024 •
edited
Loading

Hi there,
I don't think we should translate the examples lines, is it possible to remove it from the missing translation page ?

Regards,
moon.
@mooondark mooondark added question Request for information needs-review Awaiting review labels May 27, 2024
@valarnin
Copy link
Collaborator

I sort-of agree, and sort-of disagree here.

For most of the log lines, they don't need entries for other languages.

Some log lines may benefit from having other languages, e.g. Map, StartsUsing, or Ability, though I can't say for certain as I don't do any translations, nor do I write triggers against non-english log files.

Additionally, it may be good to note somewhere or somehow what documents still need translations, though that's only tangentially related to this issue. (e.g. there is no /docs/ko-KR/LogGuide.md)

Either way, until #138 and #139 are merged, we can't really flag these as not needing translation since they're being moved to a new file as part of those PRs.

@wexxlee wexxlee removed the needs-review Awaiting review label May 28, 2024
@wexxlee wexxlee self-assigned this Jun 7, 2024
@wexxlee wexxlee added the fix-me Bug report validated or feature request planned label Jun 7, 2024
@wexxlee wexxlee mentioned this issue Jun 10, 2024
Merged
wexxlee added a commit that referenced this issue Jun 10, 2024
@wexxlee
util: suppress i18n errors for example log lines (#165)
ef00e90 
Closes #157. I agree with @valarnin 's point there that certain example
log lines could benefit from translations.

But since we do not have any translated versions of `LogGuide` at the
moment, and the unit tests are all based on the `en` lines, I think it
makes sense to at least suppress the warnings for now to prevent clutter
on the `missing_translations` pages until it becomes relevant.
github-actions bot pushed a commit that referenced this issue Jun 10, 2024
gh-pages build: util: suppress i18n errors for example log lines (#165)
a8e674b 
Closes #157. I agree with @valarnin 's point there that certain example
log lines could benefit from translations.

But since we do not have any translated versions of `LogGuide` at the
moment, and the unit tests are all based on the `en` lines, I think it
makes sense to at least suppress the warnings for now to prevent clutter
on the `missing_translations` pages until it becomes relevant. ef00e90
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wexxlee wexxlee

Labels
fix-me Bug report validated or feature request planned question Request for information
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

util: suppress i18n errors for example log lines wexxlee/cactbot
3 participants
@valarnin @mooondark @wexxlee