Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Jason Turner's recommended MSVC warnings #306

Merged
merged 1 commit into from
Mar 31, 2020
Merged

Conversation

cugone
Copy link
Contributor

@cugone cugone commented Mar 30, 2020

Adds the warnings recommended by Jason Turner for MSVC as Level 4 warnings. When Treat Warnings As Errors can be turned on, these will have to change to \weXXXXto take advantage of that.

The prior Add lint rules to MSVC PR is superseded by this as the default setting is the correct Native Recommended Ruleset, albeit analysis is turned off. Although, adding to NAS2D will have to occur separately.

MSVC-only change.

Copy link
Member

@DanRStevens DanRStevens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I think I see what's going on here. Syntax is /w4nnnn, where only the last 4 digits are part of the error code. The leading 4 is the warning level it applies to. I was wondering at first why the numbers didn't seem to match what was in the thread.

@DanRStevens DanRStevens merged commit ee42adf into master Mar 31, 2020
@DanRStevens DanRStevens deleted the addJTWarnings branch March 31, 2020 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants