Fix cache related build problem - error LNK4020
#1583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we used the key from the restore step as a way of ensuring the save key would match, even if the restore key was modified. Now we have an env var with the value, so we can use that to ensure consistency between restore and save. In some cases we may skip the restore step, in which case the restore step won't have a cache key set. In those cases it's better to use the env var, which will always be set.
If the earlier restore step is skipped, then there are no output values set. In that case, the `cache-hit` output value would be blank. A blank value is not `true`. Hence the first check for `cache-hit` being not true is sufficient to cover this case too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe this fixes #1553, though we may not know for a little while if the error comes up again or not.