-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup dependencies #798
Cleanup dependencies #798
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking much nicer. Nice!
For the Jupyter-related libraries, we need a minimal environment in the I had no idea watchdog was in there. Is that library used for some form of provenance tracking?
I have some thoughts on this, but I'll add to the issue. My vote is to hold off for now. |
Co-authored-by: Trevor James Smith <[email protected]>
After our discussion from the other day, we'll go forward with the suggestion of bundling the testing dependencies into the GitHub source |
Pull Request Checklist:
bumpversion (major / minor / patch)
has been called on this branchgit push --tags
).zenodo.json
What kind of change does this PR introduce?
setup.py
except "dev". All tools needed for testing, documenting and developping xclim are listed inrequirements_dev.py
.".ipynb"
as a source suffix indocs/conf.py
. That variable, when it is a list, will associate all those files with the RST parser. Beforenbsphinx
0.8.7 (10 Aug 2021), the plugin would override the current configuration, but now it doesn't, so the bug showed itself.Does this PR introduce a breaking change?
I don't know if this count as a "breaking change", but installation options have changed.
Other information:
@Zeitsperre I removed some packages from the dev reqs:
I was able to follow all the steps of the "contributing" page of the doc. Are any of those explicitely needed by developers nonetheless? I see that some are needed for packaging, but I think we can leave them out of the dev reqs, as only you or few others will ever do that task.
I haven't addressed #795, but could do it here if people agree with the idea.