Skip to content

Fixing Inlines displaying as Editable #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: read-only-change-view
Choose a base branch
from
Open

Fixing Inlines displaying as Editable #112

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7d05e9e
Fixing Change Permission on Inlines
gascarcella Feb 21, 2020
cde1e80
Fixing Hard Coded Boolean
gascarcella Feb 21, 2020
71cf604
Set permissions on all levels based on root
OskarPersson Feb 21, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 31 additions & 6 deletions nested_inline/admin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,13 +117,18 @@ def get_media(extra_media):
if read_only:
readonly = flatten_fieldsets(list(nested_inline.get_fieldsets(request, instance)))
prepopulated = {}
nested_formset.extra = nested_formset.max_num = 0
else:
readonly = list(nested_inline.get_readonly_fields(request, instance))
prepopulated = dict(nested_inline.get_prepopulated_fields(request, instance))

wrapped_nested_formset = helpers.InlineAdminFormSet(
nested_inline, nested_formset,
fieldsets, prepopulated, readonly, model_admin=self,
has_add_permission=not read_only,
has_change_permission=not read_only,
has_delete_permission=not read_only,
has_view_permission=True,
)
wrapped_nested_formsets.append(wrapped_nested_formset)
media = get_media(wrapped_nested_formset.media)
Expand Down Expand Up @@ -286,8 +291,11 @@ def change_view(self, request, object_id, form_url='', extra_context=None):

obj = self.get_object(request, unquote(object_id))

has_change_permission = self.has_change_permission(request, obj)
has_add_permission = self.has_add_permission(request)

if request.method == 'POST':
if not self.has_change_permission(request, obj):
if not has_change_permission:
raise PermissionDenied
else:
if not self.has_view_or_change_permission(request, obj):
Expand Down Expand Up @@ -348,32 +356,49 @@ def change_view(self, request, object_id, form_url='', extra_context=None):
if hasattr(inline, 'inlines') and inline.inlines:
self.add_nested_inline_formsets(request, inline, formset)

if not self.has_change_permission(request, obj):
if not has_change_permission:
readonly_fields = flatten_fieldsets(self.get_fieldsets(request, obj))
else:
readonly_fields = self.get_readonly_fields(request, obj)

adminForm = helpers.AdminForm(
form, self.get_fieldsets(request, obj),
self.get_prepopulated_fields(request, obj) if self.has_change_permission(request, obj) else {},
self.get_prepopulated_fields(request, obj) if has_change_permission else {},
readonly_fields,
model_admin=self,
)
media = self.media + adminForm.media

can_edit_parent = self.has_change_permission(request, obj)
inline_admin_formsets = []
for inline, formset in zip(inline_instances, formsets):
fieldsets = list(inline.get_fieldsets(request, obj))
readonly = list(inline.get_readonly_fields(request, obj))
prepopulated = dict(inline.get_prepopulated_fields(request, obj))
prepopulated = dict(inline.get_prepopulated_fields(request, obj)) if has_change_permission else {}

if can_edit_parent:
inline_has_add_permission = inline.has_add_permission(request, obj)
inline_has_change_permission = inline.has_change_permission(request, obj)
inline_has_delete_permission = inline.has_delete_permission(request, obj)
else:
# Disable all edit-permissions, and overide formset settings.
inline_has_add_permission = inline_has_change_permission = inline_has_delete_permission = False
formset.extra = formset.max_num = 0

inline_has_view_permission = inline.has_view_permission(request, obj)
inline_admin_formset = helpers.InlineAdminFormSet(
inline, formset, fieldsets, prepopulated, readonly, model_admin=self,
inline, formset, fieldsets, prepopulated, readonly,
model_admin=self,
has_add_permission=inline_has_add_permission,
has_change_permission=inline_has_change_permission,
has_delete_permission=inline_has_delete_permission,
has_view_permission=inline_has_view_permission,
)
inline_admin_formsets.append(inline_admin_formset)
media = media + inline_admin_formset.media
if hasattr(inline, 'inlines') and inline.inlines:
extra_media = self.wrap_nested_inline_formsets(
request, inline, formset, self.has_change_permission(request, obj),
request, inline, formset, not has_change_permission,
)
if extra_media:
media += extra_media
Expand Down