Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set struct Item as the IsExpire() method's receiver #8

Merged
merged 1 commit into from
Apr 18, 2018
Merged

set struct Item as the IsExpire() method's receiver #8

merged 1 commit into from
Apr 18, 2018

Conversation

olshevskiy87
Copy link
Contributor

so we can:

  • reduce if-clauses to check if the item is expired
  • refuse to use the field Item.Expire unnecessarily

@olshevskiy87
set struct Item as the IsExpire() method's receiver
864260c 
so we can:
- reduce if-clauses to check if the item is expired
- refuse to use the field Item.Expire unnecessarily
@olshevskiy87
Copy link
Contributor Author

@OrlovEvgeny what do you think about this PR?

@OrlovEvgeny OrlovEvgeny merged commit a230d1a into OrlovEvgeny:master Apr 18, 2018
@OrlovEvgeny
Copy link
Owner

@olshevskiy87 merged

@olshevskiy87 olshevskiy87 deleted the t5 branch April 18, 2018 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@olshevskiy87 @OrlovEvgeny