Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

withdrawal fix to native staking strategy #2091

Merged
merged 2 commits into from
Jun 6, 2024

Conversation

naddison36
Copy link
Collaborator

Contract Changes

  • fixed updating depositedWethAccountedFor on withdrawal from NativeStakingSSVStrategy

Code Change Checklist

To be completed before internal review begins:

  • The contract code is complete
  • Executable deployment file
  • Fork tests that test after the deployment file runs
  • Unit tests *if needed
  • The owner has done a full checklist review of the code + tests

Internal review:

  • Two approvals by internal reviewers

Copy link

github-actions bot commented Jun 6, 2024

Warnings
⚠️ 👀 This PR needs at least 2 reviewers

Generated by 🚫 dangerJS against 13c0988

Copy link

codecov bot commented Jun 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.88%. Comparing base (56d3331) to head (13c0988).

Additional details and impacted files
@@                     Coverage Diff                      @@
##           sparrowDom/nativeStaking    #2091      +/-   ##
============================================================
- Coverage                     63.03%   62.88%   -0.15%     
============================================================
  Files                            65       65              
  Lines                          3246     3247       +1     
  Branches                        841      841              
============================================================
- Hits                           2046     2042       -4     
- Misses                         1197     1202       +5     
  Partials                          3        3              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@naddison36 naddison36 merged commit 563003d into sparrowDom/nativeStaking Jun 6, 2024
14 of 16 checks passed
@naddison36 naddison36 deleted the nicka/withdrawal-fix branch June 6, 2024 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant