Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy 55 OETH Curve AMO #1455

Merged
merged 145 commits into from
May 16, 2023
Merged

Deploy 55 OETH Curve AMO #1455

merged 145 commits into from
May 16, 2023

Conversation

sparrowDom
Copy link
Member

@sparrowDom sparrowDom commented May 13, 2023

Contracts deployed:

Accompanied with the #176 5/8 Governance action

Base automatically changed from sparrowDom/oeth_curve to master May 15, 2023 17:36
@DanielVF
Copy link
Collaborator

DanielVF commented May 15, 2023

  • All deployed contracts are listed in the deploy PR's description
  • Deployed contract's verified code (and all dependencies) match the code in master
  • The transactions that interacted with the newly deployed contract match the deploy script.
  • Governance proposal matches the deploy script
  • Smoke tests pass after fork test execution of the governance proposal

🔴 Oracle Router Contract does not match: https://github.com/OriginProtocol/origin-dollar/blob/master/contracts/contracts/oracle/OracleRouter.sol vs: 0x3cCD26E82F7305B12742fBb36708B42f82B61dBa However, the problem appears to be merge problems. The live contracts look good.

🔵 We'll need to lower the liquidation limit to match OUSD on CRV

@DanielVF DanielVF changed the base branch from master to DanielVF/oip-2-dripper May 16, 2023 10:51
@DanielVF DanielVF changed the base branch from DanielVF/oip-2-dripper to master May 16, 2023 10:51
@DanielVF DanielVF merged commit 90c57bb into master May 16, 2023
@DanielVF DanielVF deleted the sparrowDom/deploy_55 branch May 16, 2023 11:25
@sparrowDom
Copy link
Member Author

@DanielVF the Oracle contract that doesn't match is because of the 052 deploy that we use only on forkTest. We need that to run so that OUSD Oracle deployed on the fork matches the master codebase and tests can run against it.

Once we update the OUSD oracle that test will no longer be failing. I've actually set that test to skip in this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants