Skip to content
This repository has been archived by the owner on Oct 24, 2024. It is now read-only.

AWS container compliance - SES integration #1033

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

phyninja
Copy link
Contributor

Addresses #1011.

See related PR: #1029

If a shop admin deploys DShop from an Amazon EC2 instance, the app will now refrain from requesting the admin's AWS credentials in the Super Admin network config page. If and when the admin attempts to connect the app to their AWS SES account, the app will try to establish a connection using the EC2 "instance metadata service".

… be created programatically, using credentials from EC2 metadata. Frontend: Try foregoing the request for the user's AWS credentials when they connect to AWS SES
…er the app is running on AWS EC2. Fields displayed on the Super Admin Network config page adjust accordingly.
@phyninja phyninja requested review from mikeshultz and removed request for mikeshultz February 12, 2022 10:29
@phyninja
Copy link
Contributor Author

Front end UI testing

AWS.SES.connection.mov

Testing methodology

  1. Build a DShop Amazon Machine Image (AMI) using the scripts here
  2. Launch an EC2 instance from the AMI
  3. SSH into the instance and run
//Launch a bash shell as the user 'dshop
sudo -u dshop bash

cd /app/dshop/shop
git config --global user.name "<valid_git_username>"
git config --global user.email "<email_id_of_the_git_account>"
git pull
git checkout aws-ses-marketplace-compliance

//Manually add a .env file for testing
echo "AWS_MARKETPLACE_DEPLOYMENT=true" >> .env

yarn run build:dist
cd ../backend && pm2 restart app.js
  1. Navigate to the DShop Admin console on a web browser and test that
    a) The fields AWS Access Key and AWS Secret Access Key are hidden
    b) The user can connect to AWS SES without inputting credentials on both the Super Admin and Admin interfaces

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant