Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#58] Remove border tokens radius circle and radius pill (#58) #81

Merged
merged 1 commit into from
Sep 12, 2024
Merged

[#58] Remove border tokens radius circle and radius pill (#58) #81

merged 1 commit into from
Sep 12, 2024

Conversation

pylapp
Copy link
Member

@pylapp pylapp commented Sep 6, 2024 •
edited
Loading

Related issues

#58

Description

  • Rmeove useless border raw tokens for radius circle and radius pill

Motivation & Context

Be compliant with specifications

Types of change

  • Breaking change (fix or feature that would change existing functionality)

Previews

Checklist

Contribution

Accessibility

  • (NA) My change follows accessibility good practices

Design

  • (NA) My change respects the design guidelines of Orange Unified Design System

Development

  • My change follows the developer guide
  • I have added unit tests to cover my changes (optional)

Documentation

  • My change introduces changes to the documentation and/or I have updated the documentation accordingly

Checklist (for Core Team only)

  • The evolution have been tested and the project builds for iPhones and iPads
  • Code review has been done by reviewers according to CODEOWNERS file
  • (NA) Design review has been done
  • (NA) Accessibiltiy review has been done
  • (NA) Q/A team has tested the evolution
  • Documentation has been updated if relevant
  • Internal files have been updated if relevant (like CONTRIBUTING, DEVELOP, THIRD_PARTY, CONTRIBUTORS, NOTICE)
  • CHANGELOG has been updated respecting keep a changelog rules and reference the issues

@pylapp pylapp self-assigned this Sep 6, 2024
@pylapp pylapp requested a review from ludovic35 as a code owner September 6, 2024 12:21
@pylapp pylapp linked an issue Sep 6, 2024 that may be closed by this pull request
Tokens: Remove border-radius-circle at 50% #58
Closed
@pylapp pylapp marked this pull request as draft September 6, 2024 12:21
@pylapp pylapp marked this pull request as ready for review September 6, 2024 12:23
@pylapp
Copy link
Member Author

pylapp commented Sep 6, 2024

@ludovic35 Ready for review ;-)

@pylapp pylapp force-pushed the 58-tokens-remove-border-radius-circle-at-50 branch from bac8385 to 07068a7 Compare September 12, 2024 20:26
@pylapp pylapp force-pushed the 58-tokens-remove-border-radius-circle-at-50 branch from 07068a7 to 9fe03b1 Compare September 12, 2024 20:28
@pylapp pylapp merged commit 1bb54e4 into develop Sep 12, 2024
3 of 4 checks passed
@pylapp pylapp deleted the 58-tokens-remove-border-radius-circle-at-50 branch September 12, 2024 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ludovic35 ludovic35 ludovic35 approved these changes

Assignees

@pylapp pylapp

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tokens: Remove border-radius-circle at 50%
2 participants
@pylapp @ludovic35