Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#149] Add spacing screen in demo app #176

Merged
merged 11 commits into from
Oct 9, 2024
Merged

[#149] Add spacing screen in demo app #176

merged 11 commits into from
Oct 9, 2024

Conversation

ludovic35
Copy link
Member

@ludovic35 ludovic35 commented Oct 7, 2024 •
edited by pylapp
Loading

Note: Please transform - [ ] into - (NA) in the description when things are not applicable

Related issues

Description

Motivation & Context

Types of change

  • New feature (non-breaking change which adds functionality)

Previews

Checklist

Contribution

Accessibility

  • My change follows accessibility good practices

Design

  • My change respects the design guidelines of Orange Unified Design System

Development

  • My change follows the developer guide
  • (NA) I have added unit tests to cover my changes (optional)

Documentation

  • My change introduces changes to the documentation and/or I have updated the documentation accordingly

Checklist (for Core Team only)

  • The evolution have been tested and the project builds for iPhones and iPads
  • Code review has been done by reviewers according to CODEOWNERS file
  • (NA) Design review has been done
  • (NA) Accessibiltiy review has been done
  • (NA) Q/A team has tested the evolution
  • Documentation has been updated if relevant
  • Internal files have been updated if relevant (like CONTRIBUTING, DEVELOP, THIRD_PARTY, CONTRIBUTORS, NOTICE)
  • CHANGELOG has been updated respecting keep a changelog rules and reference the issues

@ludovic35 ludovic35 linked an issue Oct 7, 2024 that may be closed by this pull request
[Demo App] Add spacing screen #149
Closed
1 task
@ludovic35 ludovic35 force-pushed the 149-demo-app-add-spacing-screen branch from f42ce3b to 9b626f8 Compare October 7, 2024 14:27
@ludovic35 ludovic35 force-pushed the 149-demo-app-add-spacing-screen branch from cf02f4e to eba0cfe Compare October 7, 2024 15:09
@ludovic35 ludovic35 marked this pull request as ready for review October 8, 2024 09:14
pylapp
pylapp requested changes Oct 8, 2024
View reviewed changes
Copy link
Member

@pylapp pylapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Des petites choses à revoir :)

NOTICE.txt Show resolved Hide resolved
OUDS/Core/Tokens/SemanticTokens/Sources/Multiples/MultipleSpacingTokens.swift Outdated Show resolved Hide resolved
Showcase/Showcase/Pages/Utils/ShowcaseVariantElement.swift Outdated Show resolved Hide resolved
pylapp
pylapp approved these changes Oct 9, 2024
View reviewed changes
Copy link
Member

@pylapp pylapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pylapp pylapp merged commit b51e51d into develop Oct 9, 2024
3 of 4 checks passed
@pylapp pylapp deleted the 149-demo-app-add-spacing-screen branch October 9, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pylapp pylapp pylapp approved these changes

@Tayebsed93 Tayebsed93 Awaiting requested review from Tayebsed93

Assignees

@ludovic35 ludovic35

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Demo App] Add spacing screen
2 participants
@ludovic35 @pylapp