-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Token] Spacing (semantic) modifications after Figma updates (4th of October) #156
Comments
@julien-deramond FYI here is the output of the update Swift files :) The tokens car refer to other dimension semantic token, no need of transitivity @objc open var spacePaddingInlineWithIconNone: SpacingPaddingInlineSemanticToken { dimensionNone }
@objc open var spacePaddingInlineWithIconShortest: SpacingPaddingInlineSemanticToken { dimension10XS }
@objc open var spacePaddingInlineWithIconShorter: SpacingPaddingInlineSemanticToken { dimension9XS }
@objc open var spacePaddingInlineWithIconShort: SpacingPaddingInlineSemanticToken { dimension8XS }
@objc open var spacePaddingInlineWithIconMedium: SpacingPaddingInlineSemanticToken { dimension7XS }
@objc open var spacePaddingInlineWithIconTall: SpacingPaddingInlineSemanticToken { dimension5XS }
@objc open var spacePaddingInlineWithIconTaller: SpacingPaddingInlineSemanticToken { dimension3XS }
@objc open var spacePaddingInlineWithIconTallest: SpacingPaddingInlineSemanticToken { dimension2XS }
@objc open var spacePaddingInlineWithArrowNone: SpacingPaddingInlineSemanticToken { dimensionNone }
@objc open var spacePaddingInlineWithArrowShortest: SpacingPaddingInlineSemanticToken { dimension10XS }
@objc open var spacePaddingInlineWithArrowShorter: SpacingPaddingInlineSemanticToken { dimension9XS }
@objc open var spacePaddingInlineWithArrowShort: SpacingPaddingInlineSemanticToken { dimension8XS }
@objc open var spacePaddingInlineWithArrowMedium: SpacingPaddingInlineSemanticToken { dimension7XS }
@objc open var spacePaddingInlineWithArrowTall: SpacingPaddingInlineSemanticToken { dimension6XS }
@objc open var spacePaddingInlineWithArrowTaller: SpacingPaddingInlineSemanticToken { dimension4XS }
@objc open var spacePaddingInlineWithArrowTallest: SpacingPaddingInlineSemanticToken { dimension3XS } To reduce the number of variables, we gather both "mobile" (i.e. compact) and "tablet" (i.e. variants regular) @objc open var spaceScaledNone: MultipleSpacingTokens { MultipleSpacingTokens(compact: DimensionRawTokens.dimension0, regular: DimensionRawTokens.dimension0) }
@objc open var spaceScaledSmash: MultipleSpacingTokens { MultipleSpacingTokens(compact: DimensionRawTokens.dimension25, regular: DimensionRawTokens.dimension50) }
@objc open var spaceScaledShortest: MultipleSpacingTokens { MultipleSpacingTokens(compact: DimensionRawTokens.dimension50, regular: DimensionRawTokens.dimension100) }
@objc open var spaceScaledShorter: MultipleSpacingTokens { MultipleSpacingTokens(compact: DimensionRawTokens.dimension100, regular: DimensionRawTokens.dimension150) }
@objc open var spaceScaledShort: MultipleSpacingTokens { MultipleSpacingTokens(compact: DimensionRawTokens.dimension150, regular: DimensionRawTokens.dimension200) }
@objc open var spaceScaledMedium: MultipleSpacingTokens { MultipleSpacingTokens(compact: DimensionRawTokens.dimension200, regular: DimensionRawTokens.dimension300) }
@objc open var spaceScaledTall: MultipleSpacingTokens { MultipleSpacingTokens(compact: DimensionRawTokens.dimension300, regular: DimensionRawTokens.dimension400) }
@objc open var spaceScaledTaller: MultipleSpacingTokens { MultipleSpacingTokens(compact: DimensionRawTokens.dimension400, regular: DimensionRawTokens.dimension500) }
@objc open var spaceScaledTallest: MultipleSpacingTokens { MultipleSpacingTokens(compact: DimensionRawTokens.dimension500, regular: DimensionRawTokens.dimension600) }
@objc open var spaceScaledSpacious: MultipleSpacingTokens { MultipleSpacingTokens(compact: DimensionRawTokens.dimension600, regular: DimensionRawTokens.dimension700) } |
…156) Closes #156 Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
…156) Closes #156 Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
📣 New TestFlight ALPHA upload available 🚀 Please, get the new build from TestFlight app, or contact the project maintainers if you don't have access.
cc @B3nz01d @pylapp @ludovic35 @Tayebsed93 @mccart77 This is an automated message sent with love and Fastlane from our CI/CD pipeline 🤘 |
Release of version 0.4.0 See below the full CHANGELOG details. Added - [DemoApp] Update opacity screen with new design ([#200](#200)) - [DemoApp] Add color tokens screen in demo app ([#152](#152)) - [Library] Add semantic tokens `spacePaddingInlineTallest`, `spacePaddingBlockTallest`, `spaceColumnGapTaller`, `spaceColumnGapWithArrowShortest`, `spaceRowGapShortest` (Figjam final synchronization of October 16th) - [Library] Add semantic color tokens ([#124](#124)) - [DemoApp] Fix some design issues and mutualize some UI elements ([#189](#189)) - [DemoApp] Add sizing tokens screen in demo app ([#150](#150)) - [DemoApp] Add spacing tokens screen in demo app ([#149](#149)) - [Library] Add color semantic tokens `colorContentTransparentDefault`, `colorBorderTransparentDefault` and `colorBackgroundTransparentDefault` (October 8th) ([#177](#177)) - [DemoApp] On opacity screen, add a border around the view showing the opacity ([#157](#157)) Changed - [Library] Update of semantic typography tokens (Figjam final synchronization of October 16th) - [Library] Update of semantic grid tokens `gridExtraCompactColumnCount`, `gridCompactColumnGap`, `gridRegularColumnGap` (Figjam final synchronization of October 16th) - [Library] Update of semantic elevation token `elevationStickyNavigationScrolled` (Figjam final synchronization of October 16th) - [Library] Update of semantic color tokens, semantic sizing tokens (Figjam final synchronization of October 16th) - [Library/DemoApp] Updates SwiftLint rules, fix linter warnings ([#143](#143)) - [Tool] Update the templates for GitHub issues - [Tool] Improve script for documentation generation ([#168](#168)) - [Library] Rename raw brand-specific color tokens in Orange theme (no use of "brand" word) ([#179](#179)) - [Library] `fontLetterSpacingMobile*` and `fontLetterSpacingTablet*` merged in `MultipleFontLetterSpacingTokens` objects - [Library] `fontLineHeightMobile*` and `fontLineHeightTablet*` merged in `MultipleFontLineHeightTokens` objects - [Library] `fontSizeMobile*` and `fontSizeTablet*` merged in `MultipleFontSizeTokens` objects - [Library] Update semantic and raw tokens for fonts ([#155](#155)) - [Library] Update semantic tokens for fonts (October 7th) ([#172](#172)) - [Library] Update raw tokens for fonts (October 7th) ([#170](#170)) - [Library] Any semantic token of sizing `TypeXXX` has been replaced by `TypeSizeXXX` (update of October 7th) - [Library] Any semantic tokens of sizing `WithTypeXXX` has been replaced by `TypzeXXX` (update of October 7th) - [Library] Update semantic tokens for sizing (October 7th) ([#173](#173)) - [Library] Any semantic tokens of spacing `isIcon` and `isArrow` are now `withIcon` and `withArrow` (update of October 7th) - [Library] Update semantic tokens for spacing (October 4th) ([#174](#174)) - [Library] Update semantic tokens for spacing (October 4th) ([#156](#156)) - [Library] Update raw tokens for dimensions (October 7th) ([#169](#169)) Removed - [Library] Raw typography token `fontSize100` (Figjam final synchronization of October 16th) - [Library] Semantic token `spaceColumnGapWithArrowTaller` (Figjam final synchronization of October 16th) - [Library] Remove all color alias semantic tokens and any optional color tokens type uses - [Library] `SoshTheme` ([#180](#180)) - [Library] `fontSizeMobile*`, `fontSizeTablet*`, `fontLineHeightMobile*`, `fontLineHeightTablet*`, `fontLetterSpacingMobile*`, `fontLetterSpacingTablet*` removed (update of October 4th) - [Library] `spaceRowGapWithIconTaller`, `spaceColumnGapWithIconTaller` removed (update of October 7th) Fixed - [Library] `typeBodyDefaultLarge` font weight ([#191](#191)) Co-authored-by: Pierre-Yves Lapersonne <[email protected]> Co-authored-by: Ludovic Pinel <[email protected]> Co-authored-by: Tayeb Sedraia <[email protected]>
ℹ️ Released with version v0.4.0 🚀 |
Description
Some modifications have been done on Figma's side. Here's a diff showing what's been modified the 4th of October by the designers.
Sorry, the parser is not yet able to handle transitivity (that's why there are values such as "dimension7xs", etc.). Here's the mapping table to help you understand the modifications based on what you have in the library:
The text was updated successfully, but these errors were encountered: