chore: update some details in doc and remove typos

Signed-off-by: Pierre-Yves Lapersonne <[email protected]>

.github/DEVELOP.md

@@ -277,7 +277,7 @@ We can add metafields picked from [this good guideline](https://git.kernel.org/p
 This is not mandatory (yet) but a good practice and quite interesting to know who reviewed and validated what.
 You must mention *co-authors* (*Co-authored-by*). You should add who are code reviewers (*Reviewed-by*), evolutions testers (*Tested-by*) and if needed ackers (*Acked-by*).
 
-For example, for issue n°123 and its pull request n°456, tested by Anton, Iman, Maxime, Stephen, Pierre-Yves and Benoit, reviewed by Ludovic, authored by Tayeb and Pierre-Yves, and acked by Julien:
+For example, for issue n°123 and its pull request n°456, tested by Anton, Iman, Maxime, Pierre-Yves and Benoit, reviewed by Ludovic, authored by Tayeb and Pierre-Yves, and acked by Stephen:
 ```text
 refactor: update some things colors and design of the demo app (#123) (#4562)
 
@@ -287,10 +287,9 @@ Tested-by: Iman Assabah <[email protected]>
 Tested-by: Anton Astafev <[email protected]>
 Tested-by: Benoit Suzanne <[email protected]>
 Tested-by: Maxime Tonnerre <[email protected]>
-Tested-by: Stephen McCarthy <[email protected]>
 Tested-by: Pierre-Yves Ayoul <[email protected]>
 Reviewed-by: Ludovic Pinel <[email protected]>
-Acked-by: Julien Déramond <julien.deramond@orange.com>
+Acked-by: Stephen McCarthy <stephen.mccarthy@orange.com>
 Co-authored-by: Tayeb Sedraia <[email protected]>
 Co-authored-by: Pierre-Yves Lapersonne <[email protected]>
 Signed-off-by: Tayeb Sedraia <[email protected]>

DesignToolbox/fastlane/Fastfile

@@ -34,7 +34,7 @@ APPLE_KEY_CONTENT = ENV["OUDS_APPLE_KEY_CONTENT"]
 # Bundle identifier of the app
 DEVELOPER_APP_IDENTIFIER = ENV["OUDS_DEVELOPER_BUNDLE_IDENTIFIER"]
 
-# Upload To Store
+# URL for internal portal to upload to App Store
 UPLOAD_STORE_URL = ENV["OUDS_UPLOAD_STORE_URL"]
 
 # Notifications and hooks

docs_release/README.md

@@ -81,7 +81,7 @@ Fixed:
 - [Library] Fix some typos in documentation ([#89](#89))
 
 // Add in co authors anyone working on the commits being merged, add the ones who contributed (copy-paste if too lazy, use the ones you need)
-Co-authored-by: Julien Déramond <julien.deramond@orange.com>
+Co-authored-by: Benoit Suzanne <benoit.suzanne@orange.com>
 Co-authored-by: Pierre-Yves Lapersonne <[email protected]>
 Co-authored-by: Ludovic Pinel <[email protected]>
 Co-authored-by: Tayeb Sedraia <[email protected]>
@@ -103,17 +103,20 @@ You can also [look inside this commit](https://github.com/Orange-OpenSource/ouds
 - Or use _Fastlane_ command:
     ```shell
     # Variables for application signing
-    export OUDS_DEVELOPER_APP_IDENTIFIER=<your_app_identifier>
+    export OUDS_DEVELOPER_BUNDLE_IDENTIFIER=<your_app_identifier>
     export OUDS_FASTLANE_APPLE_ID=<your_apple_email_address>
     export OUDS_DEVELOPER_PORTAL_TEAM_ID=<your_developer_portal_team_ID>
     
-    # Variables to Upload to TestFlight
+    # Variables for upload to TestFlight
     export OUDS_APPLE_KEY_ID = <your_key_ID>
     export OUDS_APPLE_ISSUER_ID = <your_issuer_ID>
     export OUDS_APPLE_KEY_CONTENT = <your_key_content>
     
+    # Variables for internal portal upload (for in the end App Store)
+    export OUDS_UPLOAD_STORE_URL = <URL_wih_details_for_upload>
+
     bundle exec fastlane prod upload:true
-    # set "upload" to true if you want to upload app to TestFlight, false otherwise.
+    # set "upload" to true if you want to upload app to internal portal, false otherwise.
     ```
 
 ### Publish release to GitHub