Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

App bar top - Overflow menu colors are not correct in dark mode #349

Closed
paulinea opened this issue Nov 25, 2022 · 2 comments · Fixed by #361
Closed

App bar top - Overflow menu colors are not correct in dark mode #349

paulinea opened this issue Nov 25, 2022 · 2 comments · Fixed by #361
Labels
🐞 bug Something isn't working 👌 OK Accessibility 👌 OK Design 👌 OK PO

Comments

@paulinea
Copy link
Member

No description provided.

@paulinea paulinea added the 🐞 bug Something isn't working label Nov 25, 2022
@paulinea paulinea added the 🔍 triage A new issue that needs to be treated label Nov 29, 2022
@paulinea paulinea removed the 🔍 triage A new issue that needs to be treated label Nov 29, 2022
@paulinea paulinea self-assigned this Nov 29, 2022
paulinea added a commit that referenced this issue Dec 2, 2022
@paulinea
[#349] Add overflow menu composable in the library
36ac9d6
@paulinea paulinea linked a pull request Dec 2, 2022 that will close this issue
349 - Top app bar - Fix overflow menu colors for all themes #361
Merged
paulinea added a commit that referenced this issue Dec 2, 2022
@paulinea
[#349] Update changelog
0a0e786
paulinea added a commit that referenced this issue Dec 6, 2022
@paulinea
[#349] Review: Fix documentation
5a6c671
paulinea added a commit that referenced this issue Dec 6, 2022
@paulinea
[#349] Review: Rename "OverFlow" into "Overflow"
93cf90c
paulinea added a commit that referenced this issue Dec 6, 2022
@paulinea
[#349] Review: Replace menu items by content in the OdsDropdownMenu
b9ba009
paulinea added a commit that referenced this issue Dec 7, 2022
@paulinea
[#349] Review: Add OdsDropdownMenu preview
e6a809a
florentmaitre pushed a commit that referenced this issue Dec 7, 2022
@paulinea @florentmaitre
[#349] Add overflow menu composable in the library
b9bd3e9
florentmaitre pushed a commit that referenced this issue Dec 7, 2022
@paulinea @florentmaitre
[#349] Review: Fix documentation
48cb41b
florentmaitre pushed a commit that referenced this issue Dec 7, 2022
@paulinea @florentmaitre
[#349] Review: Rename "OverFlow" into "Overflow"
386c63e
florentmaitre pushed a commit that referenced this issue Dec 7, 2022
@paulinea @florentmaitre
[#349] Review: Replace menu items by content in the OdsDropdownMenu
fcc68db
florentmaitre pushed a commit that referenced this issue Dec 7, 2022
@paulinea @florentmaitre
[#349] Review: Add OdsDropdownMenu preview
f65f7ab
@paulinea paulinea assigned B3nz01d, mccart77 and afrahB and unassigned paulinea Dec 7, 2022
@mccart77
Copy link
Collaborator

I just took a look at this and it seems to still be an issues Version 0.8.0 (719). In dark mode the overflow menu is white with white text. the Overflow menu should be dark.

@paulinea
Copy link
Member Author

Hi @mccart77 you should test this on the last version: 0.8.0-3e2f284 (60)

@mccart77 mccart77 removed their assignment Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐞 bug Something isn't working 👌 OK Accessibility 👌 OK Design 👌 OK PO
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

349 - Top app bar - Fix overflow menu colors for all themes Orange-OpenSource/ods-android
4 participants
@paulinea @B3nz01d @mccart77 @afrahB