Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Component list page update #302

Closed
B3nz01d opened this issue Oct 26, 2022 · 2 comments · Fixed by #381
Closed

Component list page update #302

B3nz01d opened this issue Oct 26, 2022 · 2 comments · Fixed by #381
Labels
📱 demo app 🧩 enhancement New feature or request 👌 OK Accessibility 👌 OK Design 👌 OK PO ⚙️ spec review

Comments

@B3nz01d
Copy link
Collaborator

B3nz01d commented Oct 26, 2022

This page should use the small cards component to create the page. A small card should only display the title on one line.
@B3nz01d B3nz01d added 🧩 enhancement New feature or request 🔍 triage A new issue that needs to be treated 📱 demo app labels Oct 26, 2022
@paulinea
Copy link
Member

@B3nz01d The component list page already use small card components. Should we truncate and add 3 dots when the title is too long?

@paulinea
Copy link
Member

See with Benoît and Stephen, the small card should have the title on one line. Truncate it if it's too long (add 3 dots).

florentmaitre added a commit that referenced this issue Dec 15, 2022
@florentmaitre
[#302] OdsSmallCard title is now single line and truncated if needed
aaff314
@florentmaitre florentmaitre linked a pull request Dec 15, 2022 that will close this issue
302 - component - list page update #381
Merged
@paulinea paulinea removed the 🔍 triage A new issue that needs to be treated label Dec 16, 2022
paulinea pushed a commit that referenced this issue Dec 16, 2022
@florentmaitre @paulinea
[#302] OdsSmallCard title is now single line and truncated if needed
2015fef
@paulinea paulinea assigned B3nz01d and mccart77 and unassigned florentmaitre Jan 2, 2023
@B3nz01d B3nz01d assigned afrahB and unassigned B3nz01d Jan 3, 2023
@afrahB afrahB removed their assignment Jan 4, 2023
@mccart77 mccart77 removed their assignment Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
📱 demo app 🧩 enhancement New feature or request 👌 OK Accessibility 👌 OK Design 👌 OK PO ⚙️ spec review
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

302 - component - list page update Orange-OpenSource/ods-android
5 participants
@florentmaitre @paulinea @B3nz01d @mccart77 @afrahB