Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ODS-Component - OdsIconButton #294

Closed
paulinea opened this issue Oct 13, 2022 · 1 comment · Fixed by #378
Closed

ODS-Component - OdsIconButton #294

paulinea opened this issue Oct 13, 2022 · 1 comment · Fixed by #378
Labels
📱 demo app 👌 OK Accessibility 👌 OK Design 👌 OK PO

Comments

@paulinea
Copy link
Member

Add this new component in the Demo Application.

@mccart77 @B3nz01d I created this issue to avoid to forget but could you specify where this component has to be added in the demo app?
@paulinea paulinea added 🔍 triage A new issue that needs to be treated 📱 demo app ⚙️ spec review labels Oct 13, 2022
@B3nz01d
Copy link
Collaborator

B3nz01d commented Nov 2, 2022

icon buttons should be shown as a variant of the buttons in the demo app

florentmaitre added a commit that referenced this issue Dec 14, 2022
@florentmaitre
[#294] Add OdsIconButton demo
b8179a8
florentmaitre added a commit that referenced this issue Dec 14, 2022
@florentmaitre
[#294] Fix preview in OdsIconToggleButton
e4c781e
florentmaitre added a commit that referenced this issue Dec 14, 2022
@florentmaitre
[#294] Add OdsIconButton demo
e5905bc
florentmaitre added a commit that referenced this issue Dec 14, 2022
@florentmaitre
[#294] Fix preview in OdsIconToggleButton
c553931
@florentmaitre florentmaitre linked a pull request Dec 14, 2022 that will close this issue
294 - ods component - odsiconbutton #378
Merged
@paulinea paulinea removed the 🔍 triage A new issue that needs to be treated label Dec 15, 2022
florentmaitre added a commit that referenced this issue Dec 15, 2022
@florentmaitre
[#294] Add OdsIconButton demo
78a0399
florentmaitre added a commit that referenced this issue Dec 15, 2022
@florentmaitre
[#294] Fix preview in OdsIconToggleButton
e35a359
florentmaitre added a commit that referenced this issue Dec 15, 2022
@florentmaitre
[#294] Review: Some OdsIconButton methods are now internal
aaff281
@paulinea paulinea assigned B3nz01d, mccart77 and afrahB and unassigned florentmaitre Jan 2, 2023
@B3nz01d B3nz01d removed their assignment Jan 3, 2023
@afrahB afrahB removed their assignment Jan 4, 2023
@mccart77 mccart77 removed their assignment Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
📱 demo app 👌 OK Accessibility 👌 OK Design 👌 OK PO
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

294 - ods component - odsiconbutton Orange-OpenSource/ods-android
5 participants
@florentmaitre @paulinea @B3nz01d @mccart77 @afrahB