Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Demo - Add technical objects names in components detail screens #267

Closed
paulinea opened this issue Sep 9, 2022 · 2 comments · Fixed by #269
Closed

Demo - Add technical objects names in components detail screens #267

paulinea opened this issue Sep 9, 2022 · 2 comments · Fixed by #269
Labels
📱 demo app 👌 OK Accessibility 👌 OK Design 👌 OK PO

Comments

@paulinea
Copy link
Member

paulinea commented Sep 9, 2022

For all components variants add the name of the library composable as a subtile in the list items
@paulinea paulinea added 🔍 triage A new issue that needs to be treated 📱 demo app labels Sep 9, 2022
@paulinea paulinea self-assigned this Sep 12, 2022
@paulinea paulinea removed the 🔍 triage A new issue that needs to be treated label Sep 12, 2022
paulinea added a commit that referenced this issue Sep 12, 2022
@paulinea
[#267] Rename buttons composables to match with Jetpack compose SDK n…
0689d8c 
…aming
paulinea added a commit that referenced this issue Sep 12, 2022
@paulinea
[#267] Rename cards composables
d977b9b
paulinea added a commit that referenced this issue Sep 12, 2022
@paulinea
[#267] Update changelog
48b2cac
paulinea added a commit that referenced this issue Sep 13, 2022
@paulinea
[#267] Display composable name associated to each component or variant
f5efc67
@paulinea paulinea linked a pull request Sep 13, 2022 that will close this issue
267 - demo - add technical objects names in components detail screens #269
Merged
paulinea added a commit that referenced this issue Sep 13, 2022
@paulinea
[#267] Move #254 from 0.5.0 to Unreleased
2f15d95
paulinea added a commit that referenced this issue Sep 13, 2022
@paulinea
[#267] Review: Format code
a262328
paulinea added a commit that referenced this issue Sep 13, 2022
@paulinea
[#267] Review: Rename cards in documentation
4675058
@paulinea paulinea assigned B3nz01d and mccart77 and unassigned paulinea Sep 14, 2022
@B3nz01d B3nz01d removed their assignment Sep 22, 2022
@B3nz01d
Copy link
Collaborator

B3nz01d commented Sep 22, 2022

I found that the name was missing in the progress & activity page

@afrahB
Copy link

afrahB commented Sep 23, 2022 •
edited
Loading

It is necessary to associate the technical names and the components names for the vocalisation in Progress & activities .
The association is already done for all the other components.

@paulinea paulinea removed their assignment Oct 6, 2022
@mccart77 mccart77 removed their assignment Nov 15, 2022
@afrahB afrahB removed their assignment Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
📱 demo app 👌 OK Accessibility 👌 OK Design 👌 OK PO
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

267 - demo - add technical objects names in components detail screens Orange-OpenSource/ods-android
4 participants
@paulinea @B3nz01d @mccart77 @afrahB