Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug - Cards are always clickable and corner radius of ripple effect is missing #247

Closed
florentmaitre opened this issue Aug 5, 2022 · 0 comments · Fixed by #261
Closed

Bug - Cards are always clickable and corner radius of ripple effect is missing #247

florentmaitre opened this issue Aug 5, 2022 · 0 comments · Fixed by #261
Labels
🐞 bug Something isn't working ⚛️ Component 👌 OK Accessibility 👌 OK Design 👌 OK PO

Comments

@florentmaitre
Copy link
Member

No description provided.

@florentmaitre florentmaitre added 🐞 bug Something isn't working ⚛️ Component labels Aug 5, 2022
@paulinea paulinea self-assigned this Aug 30, 2022
paulinea added a commit that referenced this issue Sep 5, 2022
@paulinea
[#247] Create and use a customization state for cards
e038074
paulinea added a commit that referenced this issue Sep 5, 2022
@paulinea
[#247] Update card to be clickable only if onCardClick is not null
1315766
paulinea added a commit that referenced this issue Sep 5, 2022
@paulinea
[#247] Allow to enable or disabled click on card in customization sheet
9b48c5d
paulinea added a commit that referenced this issue Sep 5, 2022
@paulinea
[#247] Fix missing radius for card click ripple effect
961e56c
@paulinea paulinea linked a pull request Sep 5, 2022 that will close this issue
247 - bug - cards are always clickable and corner radius of ripple effect is missing #261
Merged
paulinea added a commit that referenced this issue Sep 5, 2022
@paulinea
[#247] Update changelog
7ca44ce
paulinea added a commit that referenced this issue Sep 5, 2022
@paulinea
[#247] Update changelog
9c13c71
paulinea added a commit that referenced this issue Sep 6, 2022
@paulinea
[#247] Fix compilation error by adding @ExperimentalMaterialApi annot…
928517d 
…ations
paulinea added a commit that referenced this issue Sep 6, 2022
@paulinea
[#247] Review: Fix typo
e8ea126
paulinea added a commit that referenced this issue Sep 6, 2022
@paulinea
[#247] Create and use a customization state for cards
c2ce5f0
paulinea added a commit that referenced this issue Sep 6, 2022
@paulinea
[#247] Update card to be clickable only if onCardClick is not null
4e3992b
paulinea added a commit that referenced this issue Sep 6, 2022
@paulinea
[#247] Allow to enable or disabled click on card in customization sheet
93797c5
paulinea added a commit that referenced this issue Sep 6, 2022
@paulinea
[#247] Fix missing radius for card click ripple effect
143d882
paulinea added a commit that referenced this issue Sep 6, 2022
@paulinea
[#247] Update changelog
d340740
paulinea added a commit that referenced this issue Sep 6, 2022
@paulinea
[#247] Fix compilation error by adding @ExperimentalMaterialApi annot…
4e5ba43 
…ations
paulinea added a commit that referenced this issue Sep 6, 2022
@paulinea
[#247] Review: Fix typo
7af43b1
paulinea added a commit that referenced this issue Sep 6, 2022
@paulinea
[#247] Fix compilation errors after rebase
8009713
@paulinea paulinea assigned B3nz01d and unassigned paulinea Sep 6, 2022
@B3nz01d B3nz01d removed their assignment Sep 8, 2022
@B3nz01d B3nz01d assigned mccart77, Tayebsed93 and afrahB and unassigned Tayebsed93 Sep 8, 2022
@afrahB afrahB removed their assignment Sep 8, 2022
@mccart77 mccart77 removed their assignment Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐞 bug Something isn't working ⚛️ Component 👌 OK Accessibility 👌 OK Design 👌 OK PO
Projects
None yet
Milestone
No milestone
6 participants
@florentmaitre @paulinea @Tayebsed93 @B3nz01d @mccart77 @afrahB