Skip to content

Commit

Permalink
[#360] Review: Change component name
Browse files Browse the repository at this point in the history
  • Loading branch information
dolinetouko committed Feb 15, 2023
1 parent b4cd6df commit 4682fab
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 10 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ sealed class Component(
R.string.component_sheets,
R.drawable.il_bottom_sheet,
null,
R.string.component_sheet_description,
R.string.component_sheet_bottom_description,
composableName = ""
)

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ fun ComponentSheetsBottom() {

with(customizationState) {
ComponentCustomizationBottomSheetScaffold(
titleResId = R.string.component_sheet_recipes,
titleResId = R.string.component_sheet_bottom_recipes,
bottomSheetScaffoldState = rememberBottomSheetScaffoldState(),

bottomSheetContent = {
Expand Down Expand Up @@ -81,7 +81,7 @@ fun ComponentSheetsBottom() {
.padding(top = dimensionResource(id = R.dimen.screen_vertical_margin))
.padding(horizontal = dimensionResource(id = R.dimen.screen_horizontal_margin))
) {
OdsTextBody1(text = stringResource(id = R.string.component_sheet_customize))
OdsTextBody1(text = stringResource(id = R.string.component_sheet_bottom_customize))

OdsTextSubtitle1(
text = stringResource(id = R.string.component_content),
Expand All @@ -93,8 +93,8 @@ fun ComponentSheetsBottom() {
outlinedChips = true,
modifier = Modifier.padding(top = dimensionResource(id = R.dimen.spacing_xs))
) {
OdsChoiceChip(textRes = R.string.component_sheet_empty, value = SheetsBottomCustomizationState.Content.Empty)
OdsChoiceChip(textRes = R.string.component_sheet_example, value = SheetsBottomCustomizationState.Content.Example)
OdsChoiceChip(textRes = R.string.component_sheet_bottom_empty, value = SheetsBottomCustomizationState.Content.Empty)
OdsChoiceChip(textRes = R.string.component_sheet_bottom_example, value = SheetsBottomCustomizationState.Content.Example)
}
}

Expand Down
10 changes: 5 additions & 5 deletions demo/src/main/res/values/strings.xml
Original file line number Diff line number Diff line change
Expand Up @@ -246,12 +246,12 @@

<!-- Components Sheets -->
<string name="component_sheets">Sheets : bottom</string>
<string name="component_sheet_description">Bottom sheets are surfaces anchored to the bottom of the screen that present users supplemental content.</string>
<string name="component_sheet_bottom_description">Bottom sheets are surfaces anchored to the bottom of the screen that present users supplemental content.</string>
<string name="component_content">Content</string>
<string name="component_sheet_customize">Customize the bottom sheet</string>
<string name="component_sheet_empty">Empty</string>
<string name="component_sheet_example">Example</string>
<string name="component_sheet_recipes">Recipes</string>
<string name="component_sheet_bottom_customize">Customize the bottom sheet</string>
<string name="component_sheet_bottom_empty">Empty</string>
<string name="component_sheet_bottom_example">Example</string>
<string name="component_sheet_bottom_recipes">Recipes</string>

<!-- Component Snackbars -->
<string name="component_snackbars">Snackbars</string>
Expand Down

0 comments on commit 4682fab

Please sign in to comment.