Fix various bugs in eeprom handling #46
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
24c16.h
Outdated
| @@ -8,7 +8,7 @@ typedef struct { | |||
| unsigned char address; | |||
| } t_24c16; | |||
|
|
|||
| typedef struct { | |||
| typedef struct __attribute__((packed)){ | |||
There was a problem hiding this comment.
Not a good idea. This moves the float field to a misaligned offset, and may crash with SIGBUS on some CPUs.
There was a problem hiding this comment.
What do you suggest as alternative ?? Add a stuff variable instead ?
There was a problem hiding this comment.
Is it possible to define the float inside the struct as the first item? This will reduce the padding to 1 byte. Then we can add one byte to the serial number to fill that padding byte.
Add padding for struct alignment
linuxianer99
force-pushed
the
eeprom-fix
branch
from
40c3e72 to
f3d34d3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #45