fix(api): fix ot3 calibration failing test #11617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should investigate why the refreshed position was returning a slightly different value than the non-refreshed position, but that is low priority right now. I made a ticket to track that information.
Codecov Report
@@ Coverage Diff @@
## edge #11617 +/- ##
=======================================
Coverage 75.00% 75.00%
=======================================
Files 2057 2057
Lines 57435 57435
Branches 5985 5985
=======================================
Hits 43079 43079
Misses 12949 12949
Partials 1407 1407
Flags with carried forward coverage won't be shown. Click here to find out more. |
sanni-t
approved these changes
Oct 25, 2022
|
Thanks for the quick fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should investigate why the refreshed position was returning a slightly different value than the non-refreshed position, but that is low priority right now. I made a ticket to track that information.
This fixes a test failure introduced by #11608.