xtokens config #331
Merged
xtokens config #331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
✅ Deploy Preview for docs-oz-polkadot ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
ozgunozerk
force-pushed
the
ozgun-xtokens-config
branch
from
a64764c to
cfbc952
Compare
ozgunozerk
commented
Oct 24, 2024
alistair-singh
approved these changes
Oct 24, 2024
4meta5
reviewed
Oct 24, 2024
This was referenced Oct 24, 2024
Closed
Merged
This was
linked to
issues
Oct 25, 2024
3 tasks
KitHat
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Configures
orml_xtokens.To do that, it also adds/configures the following pallets:
Quite a lot of types and some new logic is added. Followed mainly moonbeam's approach for the XCM strategies, but ofc changed/simplified some stuff. For example: we are not using
pallet_collectivesOpenTechCommitteeInstanceorovernance::custom_origins::FastGeneralAdminfor submitting new assets to or deleting existing ones from the supported asset list. I left that decision to the end-user of the template with an inline comment.