Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump versions #271

Merged
merged 3 commits into from
Aug 2, 2024
Merged

Bump versions #271

merged 3 commits into from
Aug 2, 2024

Conversation

ozgunozerk
Copy link
Collaborator

No description provided.

@ozgunozerk ozgunozerk requested review from KitHat and 4meta5 August 1, 2024 17:56
@ozgunozerk ozgunozerk self-assigned this Aug 1, 2024
Copy link

netlify bot commented Aug 1, 2024

Deploy Preview for docs-oz-polkadot ready!

Name Link
🔨 Latest commit 65c1f14
🔍 Latest deploy log https://app.netlify.com/sites/docs-oz-polkadot/deploys/66abcc3e1a208e0008eae78a
😎 Deploy Preview https://deploy-preview-271--docs-oz-polkadot.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ozgunozerk ozgunozerk changed the base branch from main to v2 August 1, 2024 17:57
Copy link
Collaborator

@ggonzalez94 ggonzalez94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just a small question regarding number version, which is non blocking and up to you

@ozgunozerk
Copy link
Collaborator Author

ozgunozerk commented Aug 1, 2024

I say yes, the "single release" stuff may change. And starting "evm" template from version 2.0.0 seems like a bad practice.

These versions also communicate the history of them, so makes sense to generic one having a different version compared to evm imo.

@KitHat
Copy link
Member

KitHat commented Aug 1, 2024

We also need to bump the docs version to publish them on the docs.openzeppelin.com

@ozgunozerk ozgunozerk merged commit b9e3640 into v2 Aug 2, 2024
2 checks passed
@ozgunozerk ozgunozerk deleted the bump-versions branch August 2, 2024 09:09
ggonzalez94 pushed a commit that referenced this pull request Aug 7, 2024
* bump versions

* bumping docs version -it was already 1.0.0 but we forgot to merge it back to main-
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

4 participants