-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[evm-template] XCM config for foreign assets #219
Conversation
✅ Deploy Preview for docs-oz-polkadot canceled.
|
For the Compiling parachain-template-runtime v1.0.0 (/Users/4meta5/oz/polkadot-runtime-template/generic-template/runtime)
error[E0277]: the trait bound `sp_runtime::AccountId32: core::default::Default` is not satisfied
--> /Users/4meta5/oz/polkadot-runtime-template/generic-template/runtime/src/configs/xcm_config.rs:175:28
|
175 | type AssetTransactor = AssetTransactors;
| ^^^^^^^^^^^^^^^^ the trait `core::default::Default` is not implemented for `sp_runtime::AccountId32`, which is required by `(FungibleAdapter<pallet_balances::Pallet<Runtime>, IsConcrete<BalancesPalletLocation>, (ParentIsPreset<sp_runtime::AccountId32>, SiblingParachainConvertsVia<polkadot_parachain_primitives::primitives::Sibling, sp_runtime::AccountId32>, AccountId32Aliases<RelayNetwork, sp_runtime::AccountId32>), sp_runtime::AccountId32, ()>, FungiblesAdapter<pallet_assets::Pallet<Runtime>, ConvertedConcreteId<u128, u128, AsAssetType<u128, AssetType, pallet_asset_manager::Pallet<Runtime>>, JustTry>, (ParentIsPreset<sp_runtime::AccountId32>, SiblingParachainConvertsVia<polkadot_parachain_primitives::primitives::Sibling, sp_runtime::AccountId32>, AccountId32Aliases<RelayNetwork, sp_runtime::AccountId32>), sp_runtime::AccountId32, NoChecking, ()>): TransactAsset`
|
= help: the following other types implement trait `TransactAsset`:
()
(TupleElement0,)
(TupleElement0, TupleElement1)
(TupleElement0, TupleElement1, TupleElement2)
(TupleElement0, TupleElement1, TupleElement2, TupleElement3)
(TupleElement0, TupleElement1, TupleElement2, TupleElement3, TupleElement4)
(TupleElement0, TupleElement1, TupleElement2, TupleElement3, TupleElement4, TupleElement5)
(TupleElement0, TupleElement1, TupleElement2, TupleElement3, TupleElement4, TupleElement5, TupleElement6)
and 23 others
= note: required for `()` to implement `sp_core::Get<sp_runtime::AccountId32>`
= note: required for `FungiblesAdapter<Pallet<Runtime>, ConvertedConcreteId<u128, u128, ..., ...>, ..., ..., ..., ...>` to implement `TransactAsset`
= note: the full type name has been written to '/Users/4meta5/oz/polkadot-runtime-template/generic-template/target/release/wbuild/parachain-template-runtime/target/wasm32-unknown-unknown/release/deps/parachain_template_runtime-35cd061f42ac92dc.long-type-10252185917316068372.txt'
= note: 1 redundant requirement hidden
= note: required for `(FungibleAdapter<Pallet<Runtime>, IsConcrete<BalancesPalletLocation>, (..., ..., ...), ..., ...>, ...)` to implement `TransactAsset`
= note: the full type name has been written to '/Users/4meta5/oz/polkadot-runtime-template/generic-template/target/release/wbuild/parachain-template-runtime/target/wasm32-unknown-unknown/release/deps/parachain_template_runtime-35cd061f42ac92dc.long-type-15556171770185959633.txt'
note: required by a bound in `staging_xcm_executor::Config::AssetTransactor`
--> /Users/4meta5/.cargo/git/checkouts/polkadot-sdk-cff69157b985ed76/7049c3c/polkadot/xcm/xcm-executor/src/config.rs:39:24
|
39 | type AssetTransactor: TransactAsset;
| ^^^^^^^^^^^^^ required by this bound in `Config::AssetTransactor`
error[E0277]: the trait bound `sp_runtime::AccountId32: core::default::Default` is not satisfied
--> /Users/4meta5/oz/polkadot-runtime-template/generic-template/runtime/src/configs/xcm_config.rs:179:23
|
179 | type FeeManager = XcmFeeManagerFromComponents<
| _______________________^
180 | | IsChildSystemParachain<primitives::Id>,
181 | | XcmFeeToAccount<Self::AssetTransactor, AccountId, XcmFeesAccount>,
182 | | >;
| |_____^ the trait `core::default::Default` is not implemented for `sp_runtime::AccountId32`, which is required by `XcmFeeManagerFromComponents<IsChildSystemParachain<ParaId>, XcmFeeToAccount<(FungibleAdapter<pallet_balances::Pallet<Runtime>, IsConcrete<BalancesPalletLocation>, (ParentIsPreset<sp_runtime::AccountId32>, SiblingParachainConvertsVia<polkadot_parachain_primitives::primitives::Sibling, sp_runtime::AccountId32>, AccountId32Aliases<RelayNetwork, sp_runtime::AccountId32>), sp_runtime::AccountId32, ()>, FungiblesAdapter<pallet_assets::Pallet<Runtime>, ConvertedConcreteId<u128, u128, AsAssetType<u128, AssetType, pallet_asset_manager::Pallet<Runtime>>, JustTry>, (ParentIsPreset<sp_runtime::AccountId32>, SiblingParachainConvertsVia<polkadot_parachain_primitives::primitives::Sibling, sp_runtime::AccountId32>, AccountId32Aliases<RelayNetwork, sp_runtime::AccountId32>), sp_runtime::AccountId32, NoChecking, ()>), sp_runtime::AccountId32, XcmFeesAccount>>: FeeManager`
|
= help: the trait `FeeManager` is implemented for `XcmFeeManagerFromComponents<WaivedLocations, FeeHandler>`
= note: required for `()` to implement `sp_core::Get<sp_runtime::AccountId32>`
= note: required for `FungiblesAdapter<Pallet<Runtime>, ConvertedConcreteId<u128, u128, ..., ...>, ..., ..., ..., ...>` to implement `TransactAsset`
= note: the full type name has been written to '/Users/4meta5/oz/polkadot-runtime-template/generic-template/target/release/wbuild/parachain-template-runtime/target/wasm32-unknown-unknown/release/deps/parachain_template_runtime-35cd061f42ac92dc.long-type-10252185917316068372.txt'
= note: 1 redundant requirement hidden
= note: required for `(FungibleAdapter<Pallet<Runtime>, IsConcrete<BalancesPalletLocation>, (..., ..., ...), ..., ...>, ...)` to implement `TransactAsset`
= note: the full type name has been written to '/Users/4meta5/oz/polkadot-runtime-template/generic-template/target/release/wbuild/parachain-template-runtime/target/wasm32-unknown-unknown/release/deps/parachain_template_runtime-35cd061f42ac92dc.long-type-15556171770185959633.txt'
= note: required for `XcmFeeToAccount<(FungibleAdapter<Pallet<Runtime>, IsConcrete<...>, ..., ..., ...>, ...), ..., ...>` to implement `HandleFee`
= note: the full type name has been written to '/Users/4meta5/oz/polkadot-runtime-template/generic-template/target/release/wbuild/parachain-template-runtime/target/wasm32-unknown-unknown/release/deps/parachain_template_runtime-35cd061f42ac92dc.long-type-316572754337197889.txt'
= note: required for `XcmFeeManagerFromComponents<IsChildSystemParachain<ParaId>, XcmFeeToAccount<(..., ...), ..., ...>>` to implement `FeeManager`
= note: the full type name has been written to '/Users/4meta5/oz/polkadot-runtime-template/generic-template/target/release/wbuild/parachain-template-runtime/target/wasm32-unknown-unknown/release/deps/parachain_template_runtime-35cd061f42ac92dc.long-type-6213363938863090770.txt'
note: required by a bound in `staging_xcm_executor::Config::FeeManager`
--> /Users/4meta5/.cargo/git/checkouts/polkadot-sdk-cff69157b985ed76/7049c3c/polkadot/xcm/xcm-executor/src/config.rs:95:19
|
95 | type FeeManager: FeeManager;
| ^^^^^^^^^^ required by this bound in `Config::FeeManager`
For more information about this error, try `rustc --explain E0277`.
error: could not compile `parachain-template-runtime` (lib) due to 2 previous errors |
…nd add to list of follow ups
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I only have a single request on my comments (moving the type
to types.rs
file). My other comments are not blockers by any means. LGTM overall.
I'm approving in advance to make things faster ⚡
Closes #215
polkadot-v1.10.1
configs/mod.rs
intoconfigs/asset_config.rs
generic-template
in favor of follow upFollow ups:
evm-template
to matchgeneric-template
#223evm-template
and configure inTrader
#224